-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_localization_component_launch): change the default input pointcloud of localization into the concatenated pointcloud #899
Merged
TaikiYamada4
merged 3 commits into
autowarefoundation:main
from
TaikiYamada4:feat/make_concat_input_default_for_localization
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
YoshiRi
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
SakodaShintaro
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that the logging_simulator
runs with the same accuracy as before on AWSIM data with GT.
Looks Good To Me
go-sakayori
added a commit
to tier4/autoware_launch
that referenced
this pull request
Aug 7, 2024
…n#899) * add parameter for force slow driving Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix Signed-off-by: Go Sakayori <gsakayori@gmail.com> * modify comment Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com>
shmpwk
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Oct 11, 2024
…n#899) * add parameter for force slow driving Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix Signed-off-by: Go Sakayori <gsakayori@gmail.com> * modify comment Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com>
go-sakayori
added a commit
to tier4/autoware_launch
that referenced
this pull request
Dec 6, 2024
…n#899) * add parameter for force slow driving Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix Signed-off-by: Go Sakayori <gsakayori@gmail.com> * modify comment Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com>
rej55
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Dec 13, 2024
…n#899) * add parameter for force slow driving Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix Signed-off-by: Go Sakayori <gsakayori@gmail.com> * modify comment Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autoware should cover the use cases where the concatenated pointcloud will be applied as an input to the localization, and we expect that the number of vehicles that use multiple LiDARs will increase..
Therefore, this PR will change the default
input_pointcloud
to/sensing/lidar/concatenated/pointcloud
instead of/sensing/lidar/top/pointcloud
, and change the pointcloud container to/pointcloud_container
due to this change.Plus, I also refactored the name of the argument
lidar_container_name
tolocalization_pointcloud_container_name
since the candidate pointcloud container may not be specific to such LiDAR (just like this case), and it makes the argument more clear that it is for the localization component.Of course, this is just a modification of the default
input_pointcloud
, so one can choose to use a single LiDAR by changing theinput_pointcloud
to/sensing/lidar/***/pointcloud
.Related links
This PR must be merged with autowarefoundation/autoware.universe#6528!!
Tests performed
Confirmed that the localization worked with the concatenated pointcloud in the logging_simulator tutorial.
Also tested with internal driving data, and evaluated through CARET that it hardly affected the system latency. [TIER IV INTERNAL LINK]
Notes for reviewers
This PR must be merged with autowarefoundation/autoware.universe#6528!!
Interface changes
The localization component will use
/sensing/lidar/concatenated/pointcloud
by default.The pointcloud preprocessing nodes in the localization component will join the
pointcloud_container
by default.Effects on system behavior
The localization component will use
/sensing/lidar/concatenated/pointcloud
by default.The pointcloud preprocessing nodes in the localization component will join the
pointcloud_container
by default.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.