chore(ground_segmentation): add default params #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
4 tasks
kminoda
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
LGTM.
Confirmed that
- Autoware launches with this PR (and related PRs).
- Parameters are successfully modified when I modify the .param.yaml file.
- ROS 2 test passes
See also: TIER IV INTERNAL LINK FOR REWORK PRs
miursh
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
4 tasks
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 13, 2024
…refoundation#947) (autowarefoundation#831) * feat(avoidance): limit acceleration during avoidance maneuver * fix(avoidance): tune longitudinal max acceleration --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
yuki-takagi-66
pushed a commit
to tier4/autoware_launch
that referenced
this pull request
Jul 8, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.