Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): use planned velocity from upstream modules #597

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Sep 27, 2023

Description

Add a flag to use the planned velocity profile from the upstream modules, especially for stop line.

Related links

feature PR: autowarefoundation/autoware.universe#5156

Tests performed

Psim

Notes for reviewers

Interface changes

none.

Effects on system behavior

none.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin changed the title feat(intersection): use upstream velocity feat(intersection): use planned velocity from upstream modules Sep 27, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin requested a review from takayuki5168 September 27, 2023 16:35
@soblin soblin merged commit 4028124 into autowarefoundation:main Sep 28, 2023
@soblin soblin deleted the feat/intersection/use-upstream-velocity-planning branch September 28, 2023 04:24
@soblin soblin restored the feat/intersection/use-upstream-velocity-planning branch September 28, 2023 04:24
@soblin soblin deleted the feat/intersection/use-upstream-velocity-planning branch September 28, 2023 04:24
takayuki5168 referenced this pull request in tier4/autoware_launch Oct 1, 2023
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
takayuki5168 referenced this pull request in tier4/autoware_launch Oct 1, 2023
feat(intersection): use planned velocity from upstream modules (#597)
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
…ng launch file (autowarefoundation#596) (autowarefoundation#597)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…efoundation#597)

* chore: disable rviz respawn when scenario_simulation is true

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: tkimura4 <tkimura4@users.noreply.github.com>
soblin added a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
sykwer pushed a commit to sykwer/autoware_launch that referenced this pull request Jan 3, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
…efoundation#597)

* chore: disable rviz respawn when scenario_simulation is true

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: tkimura4 <tkimura4@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Shohei Sakai <saka1s.jp@gmail.com>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Shohei Sakai <saka1s.jp@gmail.com>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants