-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ndt_scan_matcher): adding exe time parameter #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yvzksgl
changed the title
add critical_upper_bound_exe_time_ms for ndt
feat(ndt_scan_matcher): Adding exe time parameter
Sep 11, 2023
Please use |
yvzksgl
changed the title
feat(ndt_scan_matcher): Adding exe time parameter
feat(ndt_scan_matcher): adding exe time parameter
Sep 11, 2023
kminoda
pushed a commit
to kminoda/autoware_launch
that referenced
this pull request
Sep 13, 2023
chore: sync awf-latest
kminoda
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kminoda
approved these changes
Sep 26, 2023
Motsu-san
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was referenced Sep 26, 2023
Ericpotato
pushed a commit
that referenced
this pull request
Nov 6, 2024
chore: sync tier4/autoware_launch:awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides integration of autoware.universe and autoware_launch for localization. Adds critical_upper_bound_exe_time_ms to ndt_scan_matcher.param.yaml.
Related: autowarefoundation/autoware.universe#4916
Tests performed
All added options runned through logging simulator and test vehicle.
Effects on system behavior
It gives a facility for observing changes in nearest_voxel_transformation_likelihood and exe_time.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.