Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): adding exe time parameter #559

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

yvzksgl
Copy link
Member

@yvzksgl yvzksgl commented Sep 11, 2023

Description

This PR provides integration of autoware.universe and autoware_launch for localization. Adds critical_upper_bound_exe_time_ms to ndt_scan_matcher.param.yaml.

Related: autowarefoundation/autoware.universe#4916

Tests performed

All added options runned through logging simulator and test vehicle.

Effects on system behavior

It gives a facility for observing changes in nearest_voxel_transformation_likelihood and exe_time.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yvzksgl yvzksgl self-assigned this Sep 11, 2023
@yvzksgl yvzksgl changed the title add critical_upper_bound_exe_time_ms for ndt feat(ndt_scan_matcher): Adding exe time parameter Sep 11, 2023
@kminoda
Copy link
Contributor

kminoda commented Sep 11, 2023

Please use git commit -m "..." -s for signing off later on, as it is required by DCO.

@yvzksgl yvzksgl changed the title feat(ndt_scan_matcher): Adding exe time parameter feat(ndt_scan_matcher): adding exe time parameter Sep 11, 2023
kminoda pushed a commit to kminoda/autoware_launch that referenced this pull request Sep 13, 2023
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Motsu-san Motsu-san left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@yvzksgl yvzksgl merged commit bf07c8a into main Sep 26, 2023
@yvzksgl yvzksgl deleted the feat/ndt-diagnostics-exe-time branch September 26, 2023 07:59
yvzksgl added a commit that referenced this pull request Sep 26, 2023
Ericpotato pushed a commit that referenced this pull request Nov 6, 2024
chore: sync tier4/autoware_launch:awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants