Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rviz): respawn rviz #518

Merged
merged 1 commit into from
Aug 22, 2023
Merged

feat(rviz): respawn rviz #518

merged 1 commit into from
Aug 22, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 17, 2023

Description

rviz often dies so add respawn options

(We need to fix rviz_pulgin)

Related links

Tests performed

psim

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 kosuke55 marked this pull request as draft August 17, 2023 13:43
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review August 17, 2023 13:47
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit 9bdd7c5 into main Aug 22, 2023
@kosuke55 kosuke55 deleted the feat/respawn_rviz branch August 22, 2023 06:14
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
chore: sync awf/autoware_launch
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants