Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_launch): zero margin for outside the drivable area #468

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 20, 2023

Description

Related PR: autowarefoundation/autoware.universe#4194
TODO after this PR is merged: Fix the issue of the outside drivable area wall appears much as expected.

This PR set the stop margin for outside the drivable area to zero.

Due to the issue of the outside drivable area wall tends to appear close to the other stop wall like crosswalk, intersection, etc, the several scenarios TIER IV is maintaining failed.
image

Tests performed

scenario simulator

Effects on system behavior

Almost nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@ahmeddesokyebrahim
Due to the issue of optimization's result where the trajectory tends to be outside the drivable area around the stop point like crosswalk, intersection, etc, there was a degradation of the performance of Autoware after the PR autowarefoundation/autoware.universe#4194.

Is it okay to set the vehicle_stop_margin_outside_drivable_area to zero until the above issue will be resolved.

@takayuki5168 takayuki5168 marked this pull request as ready for review July 20, 2023 09:23
@ahmeddesokyebrahim
Copy link
Contributor

Hi @takayuki5168 ,
I have approved the change. I just have a request if you may provide more information about this optimization result where the trajectory tends to be outside the drivable area . Thanks a lot!

@takayuki5168 takayuki5168 merged commit e1da2bb into autowarefoundation:main Jul 20, 2023
@takayuki5168 takayuki5168 deleted the chore/zero-outside-drivable-length branch July 20, 2023 10:38
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
…deceleration (#468)

fix(behavior_path_planner): fix request_length and maximum_deceleration

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Oct 3, 2023
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jul 5, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants