Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): add use_raw_remote_control_command_input argument #460

Merged

Conversation

ismetatabay
Copy link
Member

@ismetatabay ismetatabay commented Jul 18, 2023

Description

This PR adds an option for using raw external commands for vehicle such as R/C controlled car.

autoware.universe PR:

releated:

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ismetatabay ismetatabay force-pushed the feat/vehicle_cmd_gate branch from e14d6e9 to cf0d789 Compare July 18, 2023 16:21
@ismetatabay ismetatabay marked this pull request as ready for review July 18, 2023 16:22
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
@ismetatabay ismetatabay marked this pull request as draft July 26, 2023 14:13
Signed-off-by: ismetatabay <ismet@leodrive.ai>
@ismetatabay ismetatabay force-pushed the feat/vehicle_cmd_gate branch from cf0d789 to dce8293 Compare July 26, 2023 17:30
@ismetatabay ismetatabay marked this pull request as ready for review July 26, 2023 17:39
use_start_request: false
enable_cmd_limit_filter: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it true by defalut

Suggested change
enable_cmd_limit_filter: false
enable_cmd_limit_filter: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TakaHoribe done 👍.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ismetatabay ismetatabay merged commit 563d1e6 into autowarefoundation:main Aug 22, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@ismetatabay ismetatabay deleted the feat/vehicle_cmd_gate branch February 27, 2024 05:15
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants