Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_simulator_launch): add use_baselink_z option for dummy_perception_publisher #304

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Apr 18, 2023

Description

PR universe: autowarefoundation/autoware.universe#3457
In current implementation of autoware, dummy_perception_publisher always uses the baselink z position while publishing dummy object. Object's Z position can not be arranged from rviz plugin. I added a parameter to make it configurable. Default value of the parameter is true.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kenji-miyake
Copy link
Contributor

@brkay54 I think it's good to have the same reviewer as autowarefoundation/autoware.universe#3457. So I'll request a review from @yukkysaito.

@kenji-miyake kenji-miyake requested review from yukkysaito and removed request for kenji-miyake April 19, 2023 03:08
…ception_publisher

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brkay54 brkay54 merged commit 26ee934 into autowarefoundation:main Apr 20, 2023
@brkay54 brkay54 deleted the use-baselink-z branch April 21, 2023 03:11
takayuki5168 referenced this pull request in tier4/autoware_launch Apr 26, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request May 7, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Apr 16, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 3, 2024
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants