-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_simulator_launch): add use_baselink_z option for dummy_perception_publisher #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
@brkay54 I think it's good to have the same reviewer as autowarefoundation/autoware.universe#3457. So I'll request a review from @yukkysaito. |
…ception_publisher Signed-off-by: Berkay Karaman <brkay54@gmail.com>
yukkysaito
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Apr 21, 2023
takayuki5168
referenced
this pull request
in tier4/autoware_launch
Apr 26, 2023
…chical motion planning flow (#304)
soblin
pushed a commit
to soblin/autoware_launch
that referenced
this pull request
May 7, 2023
…efoundation#304) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 12, 2023
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
badai-nguyen
pushed a commit
to badai-nguyen/autoware_launch
that referenced
this pull request
Apr 16, 2024
chore: sync awf/autoware_launch
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Sep 3, 2024
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR universe: autowarefoundation/autoware.universe#3457
In current implementation of autoware, dummy_perception_publisher always uses the baselink z position while publishing dummy object. Object's Z position can not be arranged from rviz plugin. I added a parameter to make it configurable. Default value of the parameter is true.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.