Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ground_segmentation): add optional param #259

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Mar 17, 2023

Description

This update parameter for autowarefoundation/autoware.universe#3106

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit a13af90 into autowarefoundation:main Mar 18, 2023
kenji-miyake referenced this pull request in tier4/autoware_launch Mar 21, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Oct 31, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jan 11, 2024
fix(start_planner): check safety only when waiting approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants