Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): add missing stop line parameter #252

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 14, 2023

Description

add missiong stop line parameter

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the chore/change-some-parameters branch from 81e18b9 to 529097e Compare March 14, 2023 18:16
@takayuki5168 takayuki5168 marked this pull request as ready for review March 15, 2023 00:27
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kenji-miyake referenced this pull request in tier4/autoware_launch Mar 21, 2023
* feat: use same parameter for system_error_monitor

* feat: launch when run_mode is psim

* feat: launch system_monitor only in online

* feat: crete launch.py

* ci(pre-commit): autofix

* fix: delete print

* feat: create dummy.param.yaml

* feat: make multi dummy diag publisher.launch.xml for each functions

* feat: add include for sensor_kit

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@takayuki5168 takayuki5168 merged commit 0f64425 into autowarefoundation:main Mar 22, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 23, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants