Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_launch): add parameter to launch launch_system_monitor #113

Merged

Conversation

ito-san
Copy link
Contributor

@ito-san ito-san commented Nov 14, 2022

Signed-off-by: ito-san fumihito.ito@tier4.jp

Description

Add launch parameter to launch system_monitor or not.
The system monitor should be configured according to system configuration but it it difficult to cover all system configurations all over the world, so we made the system_monitor optional.

  • The system_monitor launches by default but it does not launch in planning_simulator, logging_simulator, and e2e_simulator.

Related links

autowarefoundation/autoware.universe#630

Tests performed

The same tests were done described in autowarefoundation/autoware.universe#2285.
Please see this PR for details.

Notes for reviewers

Here is related PR that should be merged at the same time.
autowarefoundation/autoware.universe#2285

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ito-san <fumihito.ito@tier4.jp>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ito-san ito-san self-assigned this Nov 14, 2022
@ito-san ito-san added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 14, 2022
@kenji-miyake kenji-miyake merged commit 1d56738 into autowarefoundation:main Nov 21, 2022
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants