Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(time-based-safe-dist): improve obstacle_cruise_planner safe distance for dence urban ODD scenarios #1073

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Jul 11, 2024

Description

Closes autowarefoundation/autoware.universe#7922

Related links

autowarefoundation/autoware.universe#7485

Tests performed

Using scenario simulation

Before this PR:

2024-07-09.15-09-42.mp4

After this PR:

2024-07-15.23-04-11.mp4

Notes for reviewers

This PR is used by this autoware.universe PR

Interface changes

ROS Topic Changes

N.A

ROS Parameter Changes

Parameter Name Default Value Update Description
common.safe_distance_method "time_based" safe distance method selection from time_based and RSS
common.safe_distance_time_margin 2.0 time values used in time-based safe distance rule, e.g. 2-seconds rule, 3-seconds rule [s]

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Jul 11, 2024
Ahmed Ebrahim added 2 commits July 15, 2024 18:51
Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>
…d and rss methods

Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>
@ahmeddesokyebrahim
Copy link
Contributor Author

I will close this PR, replacing it with another approach in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dense-Urban-ODD] Improve cruise planner safe distance when cruising a front npc
1 participant