Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): add params #1038

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

SaltUhey
Copy link
Contributor

Description

Required by autowarefoundation/autoware.universe#7596

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

SaltUhey added 5 commits June 21, 2024 16:27
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
@github-actions github-actions bot added the component:ui User interface, user experience, graphical user interfaces. (auto-assigned) label Jun 21, 2024
@github-actions github-actions bot removed the component:ui User interface, user experience, graphical user interfaces. (auto-assigned) label Jun 21, 2024
@SaltUhey SaltUhey marked this pull request as ready for review June 21, 2024 08:06
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
@SaltUhey SaltUhey marked this pull request as draft June 21, 2024 08:09
Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@SakodaShintaro SakodaShintaro merged commit 3e19fdd into autowarefoundation:main Jul 5, 2024
10 of 11 checks passed
shmpwk pushed a commit to tier4/autoware_launch that referenced this pull request Jul 21, 2024
* add params (ndt_scan_matcher)

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

* fix param

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

* rviz

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

* rviz

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

* rviz

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

* style(pre-commit): autofix

* true2false

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

* Add temperature to parameters in autoware_launch

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>

---------

Signed-off-by: yuhei <yuhei1030.mini.normal@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants