Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner_common,turn_signal_decider): add turn_signal_remaining_shift_length_threshold #1007

Conversation

danielsanchezaran
Copy link
Contributor

Description

Required by autowarefoundation/autoware.universe#7160

Tests performed

PSim

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielsanchezaran danielsanchezaran changed the title feat(behavior_path_planner_common,turn_signal_decider)add turn_signal_remaining_shift_length_threshold feat(behavior_path_planner_common,turn_signal_decider): add turn_signal_remaining_shift_length_threshold May 30, 2024
@danielsanchezaran danielsanchezaran merged commit 7edbb42 into autowarefoundation:main May 30, 2024
11 of 13 checks passed
@danielsanchezaran danielsanchezaran deleted the feat/add_turn_signal_remaining_shift_length_threshold branch May 30, 2024 05:45
yuki-takagi-66 pushed a commit to tier4/autoware_launch that referenced this pull request Jul 8, 2024
…g turn signal for bpp modules (#662)

* feat(behavior_path_planner_common,turn_signal_decider): add turn_signal_remaining_shift_length_threshold (autowarefoundation#1007)

add turn_signal_remaining_shift_length_threshold

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* Turn off the turn signal sooner

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: danielsanchezaran <daniel.sanchez@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants