Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rviz): remove StringStampedOverlayDisplay reference #1001

Merged
merged 1 commit into from
May 27, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented May 27, 2024

Description

How to reproduce the bug

Compile Autoware, run planning_sim demo.
(with ros2 launch autoware_launch planning_simulator.launch.xml map_path:=$HOME/autoware_map/sample-map-planning vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit)

Bug

You will get this red rviz error. (But it will still work)

[rviz2-43] [ERROR 1716801553.757691599] [rviz2]: PluginlibFactory: The plugin for class 'rviz_plugins/StringStampedOverlayDisplay' failed to load. Error: According to the loaded plugin descriptions the class rviz_plugins/StringStampedOverlayDisplay with base class type rviz_common::Display does not exist. Declared types are  autoware_auto_perception_rviz_plugin/DetectedObjects autoware_auto_perception_rviz_plugin/PredictedObjects autoware_auto_perception_rviz_plugin/TrackedObjects autoware_mission_details_overlay_rviz_plugin/MissionDetailsDisplay autoware_overlay_rviz_plugin/SignalDisplay grid_map_rviz_plugin/GridMap rviz_default_plugins/AccelStamped rviz_default_plugins/Axes rviz_default_plugins/Camera rviz_default_plugins/DepthCloud rviz_default_plugins/Effort rviz_default_plugins/FluidPressure rviz_default_plugins/Grid rviz_default_plugins/GridCells rviz_default_plugins/Illuminance rviz_default_plugins/Image rviz_default_plugins/InteractiveMarkers rviz_default_plugins/LaserScan rviz_default_plugins/Map rviz_default_plugins/Marker rviz_default_plugins/MarkerArray rviz_default_plugins/Odometry rviz_default_plugins/Path rviz_default_plugins/PointCloud rviz_default_plugins/PointCloud2 rviz_default_plugins/PointStamped rviz_default_plugins/Polygon rviz_default_plugins/Pose rviz_default_plugins/PoseArray rviz_default_plugins/PoseWithCovariance rviz_default_plugins/Range rviz_default_plugins/RelativeHumidity rviz_default_plugins/RobotModel rviz_default_plugins/TF rviz_default_plugins/Temperature rviz_default_plugins/TwistStamped rviz_default_plugins/Wrench rviz_plugins/AccelerationMeter rviz_plugins/ConsoleMeter rviz_plugins/MaxVelocity rviz_plugins/MrmSummaryOverlayDisplay rviz_plugins/Path rviz_plugins/PathWithLaneId rviz_plugins/PolarGridDisplay rviz_plugins/PoseWithUuidStamped rviz_plugins/SteeringAngle rviz_plugins/Trajectory rviz_plugins/TurnSignal rviz_plugins/VelocityHistory rviz_plugins::PoseHistory rviz_plugins::PoseHistoryFootprint (operator()() at ./src/main.cpp:68)

Cause

When this PR merged:

It removed so many plugins from universe. And moved them to tools.repos file.

common/tier4_debug_rviz_plugin/include/tier4_debug_rviz_plugin/string_stamped.hpp This package specifically.

If you don't have tools.repos downloaded, it will give this error now.

Fix

If something is not in the autoware.repos, it should not be referenced from the default rviz. So I'm removing this.

Tests performed

Ran the planning sim demo, it worked without errors ✅

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx added bug Something isn't working component:ui User interface, user experience, graphical user interfaces. (auto-assigned) labels May 27, 2024
@xmfcx xmfcx self-assigned this May 27, 2024
@xmfcx xmfcx merged commit 6bd742f into main May 27, 2024
17 of 18 checks passed
@xmfcx xmfcx deleted the fix/remove-string-stamped-overlay branch May 27, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interface, user experience, graphical user interfaces. (auto-assigned)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants