Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error occurs with flake8 in pre-commit.ci #970

Closed
3 tasks done
SakodaShintaro opened this issue Apr 25, 2024 · 1 comment · Fixed by #971
Closed
3 tasks done

An error occurs with flake8 in pre-commit.ci #970

SakodaShintaro opened this issue Apr 25, 2024 · 1 comment · Fixed by #971
Assignees

Comments

@SakodaShintaro
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Current latest commit fails in checking with flake8 in pre-commit.ci.
9e872a2

https://results.pre-commit.ci/run/github/429697802/1713949520.mxgRbCnhTR64Czu0HVYe4w

flake8 ros...............................................................Failed
- hook id: flake8-ros
- exit code: 1

.github/update-sync-param-files.py:14:19: E231 missing whitespace after ':'
REPO_URL = f"https://github.com/{REPO_NAME}.git"
                  ^
1     E231 missing whitespace after ':'

This check is required for all pull requests, so any pull request is impossible to merge.

A related issue was found on stackoverflow.com.

https://stackoverflow.com/questions/77401175/how-to-make-flake8-ignore-syntax-within-strings

Expected behavior

pre-commit.ci flake8 passes successfully

Actual behavior

flake8 ros...............................................................Failed
- hook id: flake8-ros
- exit code: 1

.github/update-sync-param-files.py:14:19: E231 missing whitespace after ':'
REPO_URL = f"https://github.com/{REPO_NAME}.git"
                  ^
1     E231 missing whitespace after ':'

Steps to reproduce

When you submit a pull request, it will be checked automatically.

Versions

No response

Possible causes

https://stackoverflow.com/questions/77401175/how-to-make-flake8-ignore-syntax-within-strings

This issue may be resolved by increasing the version of flake8.

Additional context

No response

@SakodaShintaro SakodaShintaro self-assigned this Apr 25, 2024
@SakodaShintaro
Copy link
Contributor Author

The autoware_launch pre-commit.ci is configured in the repository below, so I would like to try to fix this.

https://github.com/tier4/pre-commit-hooks-ros/blob/main/.pre-commit-hooks.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant