-
Notifications
You must be signed in to change notification settings - Fork 72
feat: add visualization for no detection area #92
feat: add visualization for no detection area #92
Conversation
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 11.91% 11.54% -0.37%
==========================================
Files 30 30
Lines 2225 2390 +165
Branches 1175 1300 +125
==========================================
+ Hits 265 276 +11
- Misses 1540 1686 +146
- Partials 420 428 +8
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
tmp/lanelet2_extension/include/lanelet2_extension/utility/query.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I discussed with @yukkysaito and some changes are needed.
|
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
2f46176
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
…_common into feat/add-no-detection-area-filter
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@yukkysaito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yukkysaito |
@yukkysaito |
* feat: add no detection area filter Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * chore: use the string equality operator Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * chore: move the position of the function Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * feat: add function that allows to get polygons by type Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * chore: add visualization for no obstacle segmentation area Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * chore: fix typo Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * docs: add ducuments for no_obstacle_segmentation_area Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp
Description
Added visualization for the polygon tagged as
no_detection_area
Related PR:
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.