Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

feat: add visualization for no detection area #92

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Aug 5, 2022

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

Description

Added visualization for the polygon tagged as no_detection_area

Related PR:

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #92 (f2010c8) into main (68957a9) will decrease coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   11.91%   11.54%   -0.37%     
==========================================
  Files          30       30              
  Lines        2225     2390     +165     
  Branches     1175     1300     +125     
==========================================
+ Hits          265      276      +11     
- Misses       1540     1686     +146     
- Partials      420      428       +8     
Flag Coverage Δ *Carryforward flag
differential 9.82% <0.00%> (?)
total 11.91% <0.00%> (ø) Carriedforward from 5e0483b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
tmp/lanelet2_extension/lib/query.cpp 9.10% <0.00%> (-0.73%) ⬇️
tmp/lanelet2_extension/lib/visualization.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

tmp/lanelet2_extension/lib/query.cpp Outdated Show resolved Hide resolved
tmp/lanelet2_extension/lib/query.cpp Outdated Show resolved Hide resolved
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo marked this pull request as ready for review August 12, 2022 05:10
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
0x126
0x126 previously approved these changes Aug 18, 2022
Copy link

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shmpwk
shmpwk previously approved these changes Aug 18, 2022
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kenji-miyake
kenji-miyake previously approved these changes Aug 19, 2022
@TomohitoAndo
Copy link
Contributor Author

TomohitoAndo commented Aug 19, 2022

I discussed with @yukkysaito and some changes are needed.

  • change the name of no_detection_area to no_obstacle_segmentation_area and no_obstacle_segmentation_area_for_run_out
  • add library to be able to get lanelet polygon with any tag
  • add documentation for no_obstacle_segmentation_area and no_obstacle_segmentation_area_for_run_out

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo dismissed stale reviews from kenji-miyake, shmpwk, and 0x126 via 2f46176 August 23, 2022 05:44
TomohitoAndo and others added 4 commits August 24, 2022 11:18
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo
Copy link
Contributor Author

@yukkysaito
I added changes in this comment. could you please review?
#92 (comment)

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo
Copy link
Contributor Author

@yukkysaito
Could you approve runnning the workflow?
image

@TomohitoAndo
Copy link
Contributor Author

@yukkysaito
Thanks!
Could you merge this PR because I don't have the write access?
image

@yukkysaito yukkysaito merged commit 2fa6751 into autowarefoundation:main Aug 26, 2022
@TomohitoAndo TomohitoAndo deleted the feat/add-no-detection-area-filter branch August 26, 2022 13:36
1222-takeshi pushed a commit to 1222-takeshi/autoware_common that referenced this pull request Dec 2, 2022
* feat: add no detection area filter

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* chore: use the string equality operator

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* chore: move the position of the function

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* feat: add function that allows to get polygons by type

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* chore: add visualization for no obstacle segmentation area

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* chore: fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* docs: add ducuments for no_obstacle_segmentation_area

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(pre-commit): autofix

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants