-
Notifications
You must be signed in to change notification settings - Fork 72
feat(autoware_utils): add functions to generate and convert uuids #238
Conversation
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=========================================
+ Coverage 9.66% 10.46% +0.80%
=========================================
Files 40 42 +2
Lines 3115 3152 +37
Branches 1399 1407 +8
=========================================
+ Hits 301 330 +29
- Misses 2394 2395 +1
- Partials 420 427 +7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/2)
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
8b0ddb8
to
19a5927
Compare
Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lexavtanke LGTM, thanks. It'd be good to contribute this to ROS at some point, it's a functionality that everyone in the ROS community would benefit from.
I saw there was some work done in ros2/unique_identifier#1, but it hasn't had any updates in a while.
Hi @lexavtanke, Thank you for the PR. Could you create a follow-up PR to change comments here: Could you change the first line of the files you created from: |
@brkay54 this was taken from TIER IV code base. We should keep the original copyright notice. |
Description
This PR add port functions of working UUID from tier4_autoware_utils package and add some simple unit test for these functions. I need to use this functions in my work on Autoware_node in autoware.core but as tier4_autoware_utils is not the part of rosdep I get the error during build. Autoware_common is already in use in autoware.core so it is make sense to add this functions to autoware_utils.
Tests performed
Added unit tests.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.