Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

feat(lanelet2_extensions): add query curbstones from vector map #206

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

saka1-s
Copy link
Contributor

@saka1-s saka1-s commented Sep 11, 2023

Description

This PR makes enable to query curbstones from vector map.
The purpose of this feature is to publish curbstones as MarkerArray.

The background of this PR is below.
If the vector map contains a curbstone, we would like to check the position of the curbstone on rviz.
Because we need to know how much clearance do we have.
I propose adding a marker array of curbstone.
autowarefoundation/autoware.universe#4958
Screenshot from 2023-09-11 19-29-01

Tests performed

PSim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@saka1-s
Copy link
Contributor Author

saka1-s commented Sep 11, 2023

@mitsudome-r Could you please review this PR?

@saka1-s saka1-s changed the title query curbstones from vector map feat(lanelet2_extensions): add query curbstones from vector map Sep 11, 2023
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saka1-s The code looks okay, but could you write in description why you want to add this function so that we can track the reason in the future?

@mitsudome-r
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (0f7b593) 11.41% compared to head (8ee5b23) 11.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   11.41%   11.37%   -0.04%     
==========================================
  Files          36       36              
  Lines        2638     2645       +7     
  Branches     1349     1353       +4     
==========================================
  Hits          301      301              
- Misses       1917     1924       +7     
  Partials      420      420              
Flag Coverage Δ *Carryforward flag
differential 9.70% <0.00%> (?)
total 11.41% <ø> (ø) Carriedforward from 0f7b593

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
tmp/lanelet2_extension/lib/query.cpp 6.92% <0.00%> (-0.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
@saka1-s saka1-s force-pushed the feat/query-curbstones branch from deb8176 to 7aad334 Compare September 12, 2023 06:14
@saka1-s
Copy link
Contributor Author

saka1-s commented Sep 12, 2023

@mitsudome-r
Thank your review and I appreciate your help.
I update the background of PR in the description.
I also signed-off my commit and pushed again.

@mitsudome-r mitsudome-r enabled auto-merge (squash) September 13, 2023 14:35
@mitsudome-r mitsudome-r merged commit c360614 into autowarefoundation:main Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants