-
Notifications
You must be signed in to change notification settings - Fork 72
feat(lanelet2_extensions): add query curbstones from vector map #206
feat(lanelet2_extensions): add query curbstones from vector map #206
Conversation
@mitsudome-r Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@saka1-s The code looks okay, but could you write in description why you want to add this function so that we can track the reason in the future?
@saka1-s Also, DCO check is failing. Could you sign-off your commit? https://autowarefoundation.github.io/autoware-documentation/main/contributing/pull-request-guidelines/commit-guidelines/#commit-rules |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 11.41% 11.37% -0.04%
==========================================
Files 36 36
Lines 2638 2645 +7
Branches 1349 1353 +4
==========================================
Hits 301 301
- Misses 1917 1924 +7
Partials 420 420
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Shohei Sakai <saka1s.jp@gmail.com>
deb8176
to
7aad334
Compare
@mitsudome-r |
Description
This PR makes enable to query curbstones from vector map.
The purpose of this feature is to publish curbstones as MarkerArray.
The background of this PR is below.
![Screenshot from 2023-09-11 19-29-01](https://private-user-images.githubusercontent.com/19224532/267229806-a1d24693-3df1-44b9-a17e-09f78ec5fa48.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTI5MzksIm5iZiI6MTczOTU5MjYzOSwicGF0aCI6Ii8xOTIyNDUzMi8yNjcyMjk4MDYtYTFkMjQ2OTMtM2RmMS00NGI5LWExN2UtMDlmNzhlYzVmYTQ4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA0MTAzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxZmZhNzJiMDkwODQxYTVhNDQwN2EwZmM2ODlhNTkwMWE2NTA2YTFiYjFkMWI0NmYzOWY2MWY0MTM2MGNlNzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.w2hmihNKk1L58Ku8cQotk0XdLhYjNJTWrtxqrCx0f6g)
If the vector map contains a curbstone, we would like to check the position of the curbstone on rviz.
Because we need to know how much clearance do we have.
I propose adding a marker array of curbstone.
autowarefoundation/autoware.universe#4958
Tests performed
PSim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.