feat(autoware_adapi_v1_msgs): add motion api message #11
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
| @@ -16,6 +16,8 @@ rosidl_generate_interfaces(${PROJECT_NAME} | |||
| routing/srv/ClearRoute.srv | |||
| routing/srv/SetRoute.srv | |||
| routing/srv/SetRoutePoints.srv | |||
| motion/msg/MotionState.msg | |||
| motion/srv/AcceptStart.srv | |||
There was a problem hiding this comment.
Considering IsDepartureRequested is used, I feel AcceptDeparture is better.
If you have a strong opinion on this, it's fine. I'll leave it to you.
tier4/tier4_autoware_msgs#53
Or is it a different concept?
There was a problem hiding this comment.
AcceptStart means vehicle departure and resume from any stop such as stop sign or traffic signal. IsDepartureRequested is simply indicates that the speed of the command is greater than 0. After asking some people, I found that departure is not suitable for this situation, so I rename IsDepartureRequested to IsStartRequested.
There was a problem hiding this comment.
I understand. Thank you for your consideration.
cc @maxime-clem
There was a problem hiding this comment.
Signed-off-by: Takagi, Isamu isamu.takagi@tier4.jp
Description
Add the messages for motion API.
https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/list/api/motion/
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.