Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new traffic light detector artifacts download #5764

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add new traffic light detector artifacts download #5764

wants to merge 3 commits into from
+26 −0

Conversation

MasatoSaeki
Copy link

@MasatoSaeki MasatoSaeki commented Feb 12, 2025 •
edited
Loading

Description

This PR add new artifact, which is whole image traffic light detection model working on YOLOX.
Related issue is below.

How was this PR tested?

I have checked this PR like below.

Notes for reviewers

None.

Effects on system behavior

None.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen @MasatoSaeki
feat: add new tl detector artifacts download
bf38e92 
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@badai-nguyen @MasatoSaeki
chore: fix cspell
4328f0f 
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki force-pushed the feat/add_new_tlr_model_to_artifact branch 2 times, most recently from 20ab776 to 4328f0f Compare February 12, 2025 07:48
@MasatoSaeki
modify comment
a3f87bb 
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki mentioned this pull request Feb 12, 2025
Closed
@MasatoSaeki MasatoSaeki added the tag:run-health-check Run health-check label Feb 12, 2025
@MasatoSaeki MasatoSaeki marked this pull request as ready for review February 12, 2025 08:25
@MasatoSaeki MasatoSaeki mentioned this pull request Feb 12, 2025
Open
YoshiRi
YoshiRi approved these changes Feb 12, 2025
View reviewed changes
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on previous PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshiRi YoshiRi YoshiRi approved these changes

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

@youtalk youtalk Awaiting requested review from youtalk youtalk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tag:run-health-check Run health-check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasatoSaeki @YoshiRi @badai-nguyen