-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware.repos): added ros2_spconv #5658
Conversation
…n time Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
It failed without CUDA. Default behavior in Autoware packages is to skip building the CUDA packages yet report success for build 🤷 (like in autoware_lidar_centerpoint/CMakeLists.txt) |
@xmfcx |
Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@xmfcx
|
@xmfcx @mitsudome-r Currently, spconv would allow me to send PRs to BEVFusion (already sent and spconv is blocking it) and pointcloud semantic segmentation (PTv3) |
Edit: @esteve do you have any suggestions on this issue? |
@xmfcx I think the effort of hosting one package or multiple ones is the same, it wouldn't make a difference in this case. @knzo25 have you tried using https://cmake.org/cmake/help/latest/module/CheckLanguage.html#module:CheckLanguage and then https://cmake.org/cmake/help/latest/command/enable_language.html ? You could make it conditional, |
I will close this one if/once the other gets merged. I created a release in github, which allows ansible to download the package, while also addressing to some degree the versioning concerns (added the version similarly to cuda/tensorrt). If we decide to go with this, I will transfer the repo to the awf. @esteve |
Closing in favor of |
@knzo25 I see. I can always skip this repository in our buildfarm, but ideally it'd be good that the package build fails gracefully if it can't find CUDA |
Description
Temporarily adds https://github.com/knzo25/ros2_spconv
to the autoware.repos file to test compilation times
This PR is required by:
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.