Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): remove /autoware/log after colcon build #5329

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Oct 11, 2024

Description

This PR removes not only /autoware/build but also /autoware/log directories on the spot after executing colcon build.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Oct 11, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Oct 11, 2024
@youtalk youtalk marked this pull request as ready for review October 11, 2024 05:32
@youtalk youtalk requested a review from oguzkaganozt as a code owner October 11, 2024 05:32
@youtalk youtalk merged commit 2ab4f1c into main Oct 14, 2024
30 checks passed
@youtalk youtalk deleted the remove-autoware-log branch October 14, 2024 21:31
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 8, 2024
* chore(docker): remove `/autoware/log` after `colcon build` (autowarefoundation#5329)

* chore(.github): always run `Show disk space` (autowarefoundation#5354)

always show disk space

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* build(autoware.repos): remove ament_cmake fork repository (autowarefoundation#5360)

Signed-off-by: Chengyong Lin <stclin@qq.com>

* fix: remove `ndt_omp` (autowarefoundation#5390)

Removed ndt_omp

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* fix: change the organization of `awsim_sensor_kit_launch` from RobotecAI to tier4 (autowarefoundation#5403)

Fixed organization of `awsim_sensor_kit_launch` from RobotecAI to tier4

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* chore(.devcontainer): rename `.devcontainer` directories (autowarefoundation#5407)

rename .devcontainer dirs

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(docker): integrate `cuda`/`no-cuda` jobs into single job (autowarefoundation#5363)

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Chengyong Lin <stclin@qq.com>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Co-authored-by: chgyg <99009754+ChgygLin@users.noreply.github.com>
Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
youtalk added a commit to youtalk/autoware that referenced this pull request Nov 14, 2024
* chore(docker): remove `/autoware/log` after `colcon build` (autowarefoundation#5329)

* chore(.github): always run `Show disk space` (autowarefoundation#5354)

always show disk space

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* build(autoware.repos): remove ament_cmake fork repository (autowarefoundation#5360)

Signed-off-by: Chengyong Lin <stclin@qq.com>

* fix: remove `ndt_omp` (autowarefoundation#5390)

Removed ndt_omp

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* fix: change the organization of `awsim_sensor_kit_launch` from RobotecAI to tier4 (autowarefoundation#5403)

Fixed organization of `awsim_sensor_kit_launch` from RobotecAI to tier4

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>

* chore(.devcontainer): rename `.devcontainer` directories (autowarefoundation#5407)

rename .devcontainer dirs

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(docker): integrate `cuda`/`no-cuda` jobs into single job (autowarefoundation#5363)

* chore(.github): rename `bake-target` to `target-image` and add descriptions to args (autowarefoundation#5413)

* rename target-image and add descriptions

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix feedback

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* feat(docker): install CUDA development/runtime libraries only 1 time (autowarefoundation#5419)

* add base-cuda

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update svg

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* not cache cuda packages

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* push base-cuda image

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* Update docker-build-and-push.yaml

* Update docker-build-and-push-arm64.yaml

* separate jobs

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* refactor(docker): replace the multiple `rosdep` commands with `resolve_rosdep_keys.sh`. (autowarefoundation#5424)

* run resolve_rosdep_keys.sh

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* style(pre-commit): autofix

* update .dockerignore

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chmod +x

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix location

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* remove rosdep update

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(docker): replace the multiple `colcon` commands with `build_and_clean.sh`. (autowarefoundation#5425)

* run resolve_rosdep_keys.sh

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* style(pre-commit): autofix

* update .dockerignore

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chmod +x

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix location

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* remove rosdep update

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* run build_and_clean.sh

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* refactor(docker): replace the multiple `rm -rf` commands with `cleanup_system.sh`. (autowarefoundation#5426)

* fix(.github): fix `target-image` (autowarefoundation#5428)

fix target-image

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chore: remove tvm_utility artifacts from Ansible tasks (autowarefoundation#5427)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Chengyong Lin <stclin@qq.com>
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Co-authored-by: chgyg <99009754+ChgygLin@users.noreply.github.com>
Co-authored-by: SakodaShintaro <rgbygscrsedppbwg@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants