Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): remove prebuilt tag in build.sh #5044

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Jul 29, 2024

Description

After removing prebuilt stage ./docker/build.sh is failing due to missing prebuilt stage as reported here, hence we need to remove the prebuilt tag.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt self-assigned this Jul 29, 2024
@oguzkaganozt oguzkaganozt requested a review from youtalk as a code owner July 29, 2024 12:42
@oguzkaganozt oguzkaganozt requested a review from xmfcx July 29, 2024 12:44
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oguzkaganozt oguzkaganozt added the tag:run-health-check Run health-check label Jul 29, 2024
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) July 29, 2024 15:38
@oguzkaganozt oguzkaganozt disabled auto-merge July 29, 2024 15:38
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) July 29, 2024 15:38
@oguzkaganozt oguzkaganozt merged commit 4cfa28a into main Jul 29, 2024
21 checks passed
@oguzkaganozt oguzkaganozt deleted the fix/docker-build branch July 29, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants