Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ansible): add envs to local user .bashrc #4923

Merged

Conversation

amadeuszsz
Copy link
Contributor

@amadeuszsz amadeuszsz commented Jun 26, 2024

Description

While using Docker container for development as a non-root user, some of environment variables are missing. Root user and non-root user differ among environment variable. The PR populates some environment variables to /etc/skel/.bashrc files. Not all environment variables are considered here, the remaining ones are not relevant for non-root user. Actually, they will bring issues.

This PR solves #4896 and supports Autoware development using devcontainers.

Tests performed

Built locally with ./docker/build.sh --devel-only and tested with .devcontainers:

  • Building packages possible,
  • Nodes execution possible,
  • Access issues don't occur.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@amadeuszsz
Copy link
Contributor Author

"The destination directory (/etc/skel) is not writable by the current user. Error was: [Errno 13] Permission denied: b'/etc/skel/.ansible_tmpznvz9_ob.bashrc'"
Seems we have permission issue for our workflow.
@youtalk @oguzkaganozt
Could you tell me please if there is any way to apply PR's changes? The general idea is to allow full Autoware development with docker containers. If possible solution highly affects Docker image, we can close this PR and related issue.

Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @amadeuszsz !

@oguzkaganozt oguzkaganozt force-pushed the feat/add-envs-local-user branch from eb7fcdc to 66a34bc Compare July 11, 2024 13:28
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) July 11, 2024 13:30
@xmfcx xmfcx added the tag:run-health-check Run health-check label Jul 12, 2024
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
@oguzkaganozt oguzkaganozt force-pushed the feat/add-envs-local-user branch from 66a34bc to 7169804 Compare July 29, 2024 10:12
@oguzkaganozt
Copy link
Contributor

@amadeuszsz could you resolve the failed checks ?

Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
auto-merge was automatically disabled July 30, 2024 00:27

Head branch was pushed to by a user without write access

@oguzkaganozt oguzkaganozt merged commit 811a840 into autowarefoundation:main Aug 1, 2024
14 of 15 checks passed
Hangyu-Li added a commit to CATS-Lab/autoware.MKZ_Black that referenced this pull request Aug 7, 2024
feat(ansible): add envs to local user .bashrc (autowarefoundation#4923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants