-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ansible): add envs to local user .bashrc #4923
feat(ansible): add envs to local user .bashrc #4923
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @amadeuszsz !
eb7fcdc
to
66a34bc
Compare
Signed-off-by: Amadeusz Szymko <amadeusz.szymko.2@tier4.jp>
66a34bc
to
7169804
Compare
@amadeuszsz could you resolve the failed checks ? |
Signed-off-by: amadeuszsz <amadeusz.szymko.2@tier4.jp>
Head branch was pushed to by a user without write access
feat(ansible): add envs to local user .bashrc (autowarefoundation#4923)
Description
While using Docker container for development as a non-root user, some of environment variables are missing. Root user and non-root user differ among environment variable. The PR populates some environment variables to
/etc/skel/.bashrc
files. Not all environment variables are considered here, the remaining ones are not relevant for non-root user. Actually, they will bring issues.This PR solves #4896 and supports Autoware development using devcontainers.
Tests performed
Built locally with
./docker/build.sh --devel-only
and tested with.devcontainers
:Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.