Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: escape install task if the specific package is held #4584

Conversation

Naophis
Copy link
Contributor

@Naophis Naophis commented Apr 2, 2024

Description

When a user, who wants to continue operating Autoware on a specific version of "ros-distro-desktop", executes the setup-dev-env.sh with the ROS packages already held, the installation of ROS 2 fails, and all other installation roles , such as fetching the latest ONNX files, are not executed.

This PR changes is escaping the ROS 2 installation process and issuing a warning when it's already held.

Tests performed

  • Before testing, all of ROS packages are held.
    image
  • Result of setup-dev-env.sh. Failed and other roles are not executed.
    image
  1. If ros-humble-desktop is held and other dependencies package is held.
  • install: skipped (OK)
  • warining: output (OK)
    image
  1. The ros-humble-desktop is not held and others is held.
  • install: changed (OK)
  • warining: skipped (OK)
    image

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Naophis
Copy link
Contributor Author

Naophis commented Apr 2, 2024

I forgot signed-off.

@Naophis Naophis deleted the feat/escape_held_package_install branch April 2, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant