Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rosbag_controller_split #2046

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Feature/rosbag_controller_split #2046

merged 2 commits into from
Mar 8, 2019

Conversation

ChenxiTU
Copy link

Status

DEVELOPMENT

Description

Add two new feature for rosbag controller:

  1. Now we can set max size (GB) or max during (min) for recording, support input decimals.
  2. When using configure file to specif topics, topics specified by configure file will also be showed by Topic Refresh with other existing topics. If topics specified by configure file not exist (have not been published yet), we will give a warning.

Todos

  • Tests

Steps to Test

  1. Start rviz and choose Panels->Add New Panel->RosbagController
  2. You can use the plugin to record rosbags with specified topics (do not specify any topics means recording all)

@ChenxiTU ChenxiTU changed the title new feature: split and warning Feature/rosbag_controller_split Feb 28, 2019
isamu-takagi
isamu-takagi approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kitsukawa kitsukawa merged commit 2ee0c45 into develop Mar 8, 2019
@kitsukawa kitsukawa deleted the feature/rosbag_controller_split branch March 8, 2019 06:08
@ChenxiTU ChenxiTU mentioned this pull request Mar 14, 2023
Closed
17 tasks
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@ChenxiTU
Feature/rosbag_controller_split (autowarefoundation#2046)
cb144da 
* new feature: split and warning

* fix bugs; add absolute path with default filename
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsukawa kitsukawa kitsukawa approved these changes

@isamu-takagi isamu-takagi isamu-takagi approved these changes

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChenxiTU @kitsukawa @isamu-takagi @mitsudome-r