Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/point pillars #2029
Feature/point pillars #2029
Changes from 20 commits
1b5a90b
6b1f65c
a9a8cf9
49f6fba
7c4c1d6
0a784b6
978a5d6
9cd5b71
b4fee92
663f4f1
36d9d10
267467d
37ee941
036aba6
602d21c
c6414f7
65fd094
b60a3e5
18a39e0
0f9d824
e7fde83
6512482
5904fd1
4c1339b
b350ec9
1053510
60f3a12
a384528
367bcb1
b5cd3ff
3e226ac
7daa788
a04b5ac
c59fa71
7b9cd43
d67f2ec
816ba2d
d17e4b4
4b6b0ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbiggs @esteve @kfunaoka this package uses a pre-trained network that is not for commercial purposes.
I think that we need to find a way to clearly mark such packages, otherwise it will be difficult to find them later and it will also cause confusion with Autoware users trying to commercialize such packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree. I'll add it to my notes for the documentation template.
I think we also need a way for a user to easily select between using a non-commercial pre-trained network that we provide and a network they provide themselves (as well as a good method and documentation for how to train a network). This would improve the usefulness of Autoware without placing a burden on us to provide trained networks. I'll add this to my increasing pile of notes on what Autoware should be. :)