Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test twist gate #2028

Merged
merged 21 commits into from
Mar 9, 2019

Conversation

s-azumi
Copy link

@s-azumi s-azumi commented Feb 26, 2019

Status

DEVELOPMENT

Description

Added tests for changes by #1609

Related PRs

#1609

@s-azumi s-azumi mentioned this pull request Feb 26, 2019
7 tasks
@s-azumi
Copy link
Author

s-azumi commented Feb 28, 2019

In order to pass the test, it is necessary to fix autoware health checker. #2012

Copy link

@sgermanserrano sgermanserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-azumi can you add tests for the functions that are not currently touched?

@s-azumi
Copy link
Author

s-azumi commented Mar 7, 2019

@sgermanserrano I added tests what I can add immediately although it is not perfect.

change directry of twist_gate.h
@s-azumi
Copy link
Author

s-azumi commented Mar 8, 2019

@sgermanserrano That is the test I can add right now.
Could you review this again?

@s-azumi s-azumi requested a review from sgermanserrano March 8, 2019 06:56
@kfunaoka kfunaoka merged commit 11a546d into feature/rebuild_decision_maker Mar 9, 2019
@kfunaoka kfunaoka deleted the feature/test_twist_gate branch March 9, 2019 12:50
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants