Fix/colcon build #2000
Merged
Fix/colcon build #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
approved these changes
Feb 18, 2019
esteve
approved these changes
Feb 18, 2019
docker/generic/Dockerfile.kinetic
Outdated
| @@ -9,7 +9,7 @@ RUN apt-get update && apt-get install -y \ | |||
| libflann-dev \ | |||
| libgsl0-dev \ | |||
| libgoogle-perftools-dev \ | |||
| libeigen3-dev | |||
| libeigen3-dev sudo gconf2 | |||
There was a problem hiding this comment.
Looks great. Just a minor thing, could you break this down into separate lines and sort them alphabetically?
amc-nu
suggested changes
Feb 19, 2019
docker/generic/Dockerfile.kinetic
Outdated
| @@ -62,7 +66,7 @@ RUN sudo rosdep init \ | |||
| # Install Autoware | |||
| RUN cd && mkdir /home/$USERNAME/Autoware | |||
| COPY --chown=autoware ./ /home/$USERNAME/Autoware/ | |||
| RUN /bin/bash -c 'source /opt/ros/kinetic/setup.bash; cd /home/$USERNAME/Autoware/ros/src; git submodule update --init --recursive; catkin_init_workspace; cd ../; rosdep install -y --from-paths /home/$USERNAME/Autoware/ros/src --ignore-src --rosdistro kinetic; ./catkin_make_release' | |||
| RUN /bin/bash -c 'source /opt/ros/kinetic/setup.bash; cd /home/$USERNAME/Autoware/ros/src; git submodule update --init --recursive; cd ../; rosdep install -y --from-paths /home/$USERNAME/Autoware/ros/src --ignore-src --rosdistro kinetic; ./colcon_release' | |||
| RUN echo "source /home/$USERNAME/Autoware/ros/devel/setup.bash" >> /home/$USERNAME/.bashrc | |||
There was a problem hiding this comment.
needs to point to install space instead of devel
Suggested change
| RUN echo "source /home/$USERNAME/Autoware/ros/devel/setup.bash" >> /home/$USERNAME/.bashrc | |
| RUN echo "source /home/$USERNAME/Autoware/ros/install/setup.bash" >> /home/$USERNAME/.bashrc |
docker/generic/Dockerfile.kinetic
Outdated
| @@ -62,7 +66,7 @@ RUN sudo rosdep init \ | |||
| # Install Autoware | |||
| RUN cd && mkdir /home/$USERNAME/Autoware | |||
| COPY --chown=autoware ./ /home/$USERNAME/Autoware/ | |||
| RUN /bin/bash -c 'source /opt/ros/kinetic/setup.bash; cd /home/$USERNAME/Autoware/ros/src; git submodule update --init --recursive; catkin_init_workspace; cd ../; rosdep install -y --from-paths /home/$USERNAME/Autoware/ros/src --ignore-src --rosdistro kinetic; ./catkin_make_release' | |||
| RUN /bin/bash -c 'source /opt/ros/kinetic/setup.bash; cd /home/$USERNAME/Autoware/ros/src; git submodule update --init --recursive; cd ../; rosdep install -y --from-paths /home/$USERNAME/Autoware/ros/src --ignore-src --rosdistro kinetic; ./colcon_release' | |||
There was a problem hiding this comment.
I recommend using sudo -E in the script to allow the build arguments to be passed. This is useful when running behind a proxy.
Suggested change
| RUN /bin/bash -c 'source /opt/ros/kinetic/setup.bash; cd /home/$USERNAME/Autoware/ros/src; git submodule update --init --recursive; cd ../; rosdep install -y --from-paths /home/$USERNAME/Autoware/ros/src --ignore-src --rosdistro kinetic; ./colcon_release' | |
| RUN /bin/bash -c 'source /opt/ros/kinetic/setup.bash; cd /home/$USERNAME/Autoware/ros/src; git submodule update --init --recursive; cd ../; sudo -E rosdep install -y --from-paths /home/$USERNAME/Autoware/ros/src --ignore-src --rosdistro kinetic; ./colcon_release' |
amc-nu
approved these changes
Feb 19, 2019
|
@esteve @amc-nu I have undone the changes to the Dockerfile to keep the aim of the PR clean. The needed changes are mentioned in autowarefoundation/autoware_ai#563 in any case for testing purposes. |
anubhavashok
pushed a commit
to NuronLabs/autoware.ai
that referenced
this pull request
Sep 7, 2021
* Added lcuda link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
PRODUCTION / DEVELOPMENT
Description
As described in autowarefoundation/autoware_ai#563