Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/spinnaker #1984

Merged
merged 19 commits into from
Feb 19, 2019
Merged

Feature/spinnaker #1984

merged 19 commits into from
Feb 19, 2019

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Feb 14, 2019

Status

DEVELOPMENT

Description

ROS driver for pointgrey cameras such as Black Fly S using Spinnaker SDK.
autowarefoundation/autoware_ai#533

Steps to Test or Reproduce

From a terminal:

roslaunch autoware_pointgrey_drivers spinnaker.launch

From RTM:
Sensing Tab -> Spinnaker

@wep21 wep21 requested a review from amc-nu February 14, 2019 12:59
Copy link

@sgermanserrano sgermanserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wep21 can you add the install directives to the CMakelists?

@wep21 wep21 requested a review from aohsato February 15, 2019 06:07
* Don't force raw image format
* Removed mutex causing multiple cameras to don't publish
* Removed crash due to the use of incompatible API on a camera
* Switched to ROS logging instead of std out
* Commented DLTL code
@amc-nu
Copy link
Member

amc-nu commented Feb 15, 2019

@sgermanserrano Added the install commands, and applied clang format

@amc-nu amc-nu merged commit b3a8654 into develop Feb 19, 2019
@amc-nu amc-nu deleted the feature/spinnaker branch February 19, 2019 03:12
@ubercool2
Copy link

@wep21 @amc-nu is Spinnaker an alternative to FlyCapture2? Does Autoware support now both or just one?

@amc-nu
Copy link
Member

amc-nu commented Feb 26, 2019

It is an alternative.
Both are supported.

anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
* add spinnaker driver

* modified for multithreading

* fix CMakeLists.txt

* fix CMakeLists.txt

* fix spinnaker launch file

* delete unused files

* fix maintainer

* fix thread function

* add license and fix default value

* modify README

* modify computing.yml

* * Added install commands
* Don't force raw image format
* Removed mutex causing multiple cameras to don't publish
* Removed crash due to the use of incompatible API on a camera
* Switched to ROS logging instead of std out
* Commented DLTL code

* Removed namespace and pixel format

* enable to change fps

check device type and set DeviceLinkThroughputLimit

* Check pointers' validity

* applied clang format
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants