Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gazebo simulator #1930

Merged
merged 60 commits into from
Feb 22, 2019
Merged

Feature/gazebo simulator #1930

merged 60 commits into from
Feb 22, 2019

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented Jan 28, 2019

Status

PRODUCTION / DEVELOPMENT

Description

https://github.com/CPFL/Autoware/issues/1907
In the initial release, it runs with runtime manager, but ultimately the UI is maintained with a new autoware launcher

https://github.com/CPFL/Autoware/tree/feature/autoware_launcher_py

Todos

  • Documentation

@yukkysaito yukkysaito requested a review from aohsato January 28, 2019 07:55
Copy link

@aohsato aohsato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.
Do you want to perfectly deprecate system/gazebo/*, right? Please describe deprecation and the overview of your simulator to #1907.

@aohsato
Copy link

aohsato commented Jan 29, 2019

screenshot from 2019-01-29 18-51-07
And my car respawned in the bushes... ;)

@yukkysaito
Copy link
Contributor Author

screenshot from 2019-01-29 18-51-07
And my car respawned in the bushes... ;)

Thank you. fixed bug
f2944cf

@sgermanserrano
Copy link

@yukkysaito the velodyne_simulator metapackage should not be added as a dependency. #1985

Copy link

@aohsato aohsato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than before, good job.
It is possible to fix details even after merging, so these are just my comments.

@aohsato
Copy link

aohsato commented Feb 22, 2019

@yukkysaito Great contribution! In the near future, let's integrate real/sim descriptions and create the general package.

@yukkysaito yukkysaito merged commit cc23c89 into develop Feb 22, 2019
@amc-nu amc-nu deleted the feature/gazebo_simulator branch March 23, 2019 07:03
@sgermanserrano
Copy link

sgermanserrano commented Apr 2, 2019

@yukkysaito is there any difference between your/CPFL car_demo fork and the upstream version?

anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants