fix rosbag_controller license #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsukawa
approved these changes
Jan 25, 2019
|
@ChenxiTU are the changes in the code closely linked to Autoware? or would they also benefit the wider ROS community? if the latter, it might be worth trying to make the update upstream to reduce the amount of code that needs to be maintained within the Autoware project |
|
@sgermanserrano Thanks for your advice. In order to support rosbag_controller, I modify some parts in the code. I think it has some conflict with its original version in ROS. So maybe it's better to keep it alone. |
kfunaoka
reviewed
Jan 28, 2019
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * |
There was a problem hiding this comment.
Suggested change
| * | |
| ******************************************************************** |
kfunaoka
reviewed
Jan 28, 2019
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * |
There was a problem hiding this comment.
Suggested change
| * | |
| ******************************************************************** |
|
@kfunaoka Thanks for your advice. You are right, now licenses are split. |
anubhavashok
pushed a commit
to NuronLabs/autoware.ai
that referenced
this pull request
Sep 7, 2021
* fix rosbag_controller license * split two licenses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the license violations
https://github.com/CPFL/Autoware/blob/develop/ros/src/util/packages/autoware_rviz_plugins/rosbag_controller/src/core/recorder.cpp
copied from
https://github.com/ros/ros_comm/blob/kinetic-devel/tools/rosbag/src/recorder.cpp
https://github.com/CPFL/Autoware/blob/develop/ros/src/util/packages/autoware_rviz_plugins/rosbag_controller/src/core/recorder.h
copied from
https://github.com/ros/ros_comm/blob/kinetic-devel/tools/rosbag/include/rosbag/recorder.h
Not 100% copy, I add some other functions to support rest codes.
Apache license is now appended before original BSD Licenses for two files mentioned before.