-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove obsolete lidar kf contour track #1842
Fix/remove obsolete lidar kf contour track #1842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hatem-darweesh mentioned this one is not obsolete
@hatem-darweesh Would you explain why lidar_kf_contour_track is important for OpenPlanner? In my understanding, OpenPlanner is independent from tracking algorithms, and can use other tracking algorithms. @cirpue49 Do lidar_kf_contour_track and lidar_imm_ukf show similar tracking performance? |
@kfunaoka it is different approach to track detected objects,
Sorry I didn't saw the nodes list earlier ! |
@hatem-darweesh It seems we can brush up the design between OpenPlanner and Tracking not to locked in lidar_kf_contour_track. Adding the two features into every tracking algorithms might reduce the maintainability. For now, let's keep as-is regarding lidar_kf_contour_track until the design is brushed up :) |
@hatem-darweesh sorry about that, I took a look at the packages that depend on |
@esteve don't know about other lidar_* nodes, |
@hatem-darweesh no problem at all keeping it :-) Thanks for checking, I'm closing this PR. |
Status
PRODUCTION / DEVELOPMENT
Description
Obsolete according to https://docs.google.com/spreadsheets/d/1wcMiQJFr3SwHAS9H21UbcmnmMMDvq04Jpa7uGml0MdI/edit
Connects to autowarefoundation/autoware_ai#475