Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove obsolete lidar kf contour track #1842

Closed
wants to merge 1 commit into from
Closed

Fix/remove obsolete lidar kf contour track #1842

wants to merge 1 commit into from

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jan 8, 2019

Copy link

@sgermanserrano sgermanserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hatem-darweesh mentioned this one is not obsolete

@kfunaoka
Copy link

kfunaoka commented Jan 8, 2019

#1846 (comment)

lidar_kf_contour_track is very important for OpenPlanner.
it follows the same object tracking node interface. same as (lidar_imm_ukf) with similar performance according to kitti evaluation

@hatem-darweesh Would you explain why lidar_kf_contour_track is important for OpenPlanner? In my understanding, OpenPlanner is independent from tracking algorithms, and can use other tracking algorithms.

@cirpue49 Do lidar_kf_contour_track and lidar_imm_ukf show similar tracking performance?

@hatem-darweesh
Copy link

@kfunaoka it is different approach to track detected objects,

  • I evaluated this tracking node using KITTI , and I got close results as imm_ukf.

  • Two important features that I added to this node:

  1. It supports the simulated (Ego, Other) vehicles I can track with specific ID's
  2. I can do frame by frame debugging in simulation mode

Sorry I didn't saw the nodes list earlier !

@kfunaoka
Copy link

kfunaoka commented Jan 9, 2019

@hatem-darweesh It seems we can brush up the design between OpenPlanner and Tracking not to locked in lidar_kf_contour_track. Adding the two features into every tracking algorithms might reduce the maintainability. For now, let's keep as-is regarding lidar_kf_contour_track until the design is brushed up :)

@esteve
Copy link
Contributor Author

esteve commented Jan 9, 2019

@hatem-darweesh sorry about that, I took a look at the packages that depend on jsk_recognition_msgs (because that's one of the dependencies that prevent us to migrate to ROS Melodic) and are declared as obsolete. Should any of the other lidar_* packages be removed?

@hatem-darweesh
Copy link

@esteve don't know about other lidar_* nodes,
will lidar_kf_contour_track be a problem to leave?

@esteve
Copy link
Contributor Author

esteve commented Jan 10, 2019

@hatem-darweesh no problem at all keeping it :-) Thanks for checking, I'm closing this PR.

@esteve esteve closed this Jan 10, 2019
@esteve esteve deleted the fix/remove_obsolete_lidar_kf_contour_track branch January 10, 2019 12:28
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants