Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Baidu's CNN based LiDAR segmentation #1800

Merged
merged 18 commits into from
Feb 18, 2019
Merged

[feature] Baidu's CNN based LiDAR segmentation #1800

merged 18 commits into from
Feb 18, 2019

Conversation

amc-nu
Copy link
Member

@amc-nu amc-nu commented Dec 21, 2018 •
edited
Loading

Status

PRODUCTION / DEVELOPMENT

Description

autowarefoundation/autoware_ai#466

Steps to Test or Reproduce

Follow README contained in the package.

@AbangLZU AbangLZU mentioned this pull request Jan 2, 2019
Closed
@kfunaoka kfunaoka mentioned this pull request Mar 14, 2023
Closed
17 tasks
@k0suke-murakami
Copy link

@amc-nu
Can you add an appropriate license for each file?
Some files lack license information.

k0suke-murakami
k0suke-murakami approved these changes Jan 31, 2019
View reviewed changes
Copy link

@k0suke-murakami k0suke-murakami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I confirmed this node works without any problems.
LGTM

@amc-nu amc-nu merged commit a5ca57a into develop Feb 18, 2019
@k0suke-murakami k0suke-murakami deleted the feature/cnnseg_from_apollo branch March 15, 2019 08:17
@dejanpan
Copy link

@amc-nu @k0suke-murakami couple of questions here:

  1. How exactly is this different from https://github.com/ApolloAuto/apollo/tree/master/modules/perception/lidar/lib/segmentation/cnnseg? What has been copied directly from Apollo repo?
  2. How much of other code from Apollo have we copied into Autoware already?
  3. Why has this PR almost 2000 lines of code and only one meaningful comment: [feature] Baidu's CNN based LiDAR segmentation #1800 (comment)?
  4. @k0suke-murakami how did you test it?
  5. Why again 0 tests?
  6. Why again 0 comments?
  7. Which models do you download from Apollo? Did you make sure 100% sure that their pre-trained models are also Apache 2.0?

I thought that we wanted to monitor new contributions into Autoware.AI a little bit more.

Also we said that we won't be copying code from other sources anymore (as we did before with e.g. pointgray and velodyne drivers).

@gbiggs @kfunaoka ?

@gbiggs
Copy link

gbiggs commented Mar 24, 2019 •
edited
Loading

I thought that we wanted to monitor new contributions into Autoware.AI a little bit more.

This PR was made before I started. I certainly wouldn’t have accepted it with so few tests, comments and documentation.

anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@amc-nu
[feature] Baidu's CNN based LiDAR segmentation (autowarefoundation#1800)
05fbf47 
* Add build caffe

* add include apollo files

* add apollo cnn

* calculating time

* * Cleaned node
* Parametrized inputs
* Works with custom caffe

* * Parameterized
* Works with custom Caffe
* Removed hard coded params
* Cleaned up dependencies
* Added bboxes, labels
* Minor fixes

* Custom input topic

* Added UI, launch file, readme

* Added Compatibility for Perception Cleanup

* * Added license messages
* Updated readme

* Added extra instructions

* Fix markdown
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0suke-murakami k0suke-murakami k0suke-murakami approved these changes

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amc-nu @k0suke-murakami @dejanpan @gbiggs @mitsudome-r @koh-murakami-ai