Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add lidar frame to wf_simulator #1710

Merged
merged 2 commits into from
Nov 21, 2018
Merged

[Feature] Add lidar frame to wf_simulator #1710

merged 2 commits into from
Nov 21, 2018

Conversation

aohsato
Copy link

@aohsato aohsato commented Nov 13, 2018 •
edited by yn-mrse
Loading

Status

DEVELOPMENT

Description

I added /sim_lidar tf frame to wf_simulator node, mainly for using lidar_fake_perception autowarefoundation/autoware_ai#250 same time.

Todos

  • Tests

Steps to Test or Reproduce

  1. Launch wf_simulator and set initial pose
  2. You can see /sim_base_link and /sim_lidar frames on /map coordinate

@aohsato aohsato requested review from yk-fujii and yn-mrse November 13, 2018 10:33
@aohsato aohsato changed the title Feature/wf simulator lidar frame [Feature] Add lidar frame to wf_simulator Nov 13, 2018
yn-mrse
yn-mrse approved these changes Nov 21, 2018
View reviewed changes
Copy link

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! I approve of this change.

@aohsato aohsato merged commit d0ee3d2 into develop Nov 21, 2018
@aohsato aohsato deleted the feature/wf_simulator_lidar_frame branch November 21, 2018 15:41
@aohsato
Copy link
Author

aohsato commented Nov 21, 2018

@yn-mrse 👍

anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@aohsato
Merge pull request autowarefoundation#1710 from CPFL/feature/wf_simul…
77d3014 
…ator_lidar_frame

[Feature] Add lidar frame to wf_simulator
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yn-mrse yn-mrse yn-mrse approved these changes

@yk-fujii yk-fujii Awaiting requested review from yk-fujii

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aohsato @yn-mrse @mitsudome-r