Feature/perception visualization cleanup #1648

amc-nu · 2018-10-26T05:06:43Z

Status

PRODUCTION / DEVELOPMENT

Description

Implements autowarefoundation/autoware_ai#379

Related PRs

autowarefoundation/autoware_ai#378

Steps to Test or Reproduce

New VisualizationNode will subscribe to DetectedObjectArray and publish:

All the visualization Markers in a single topic
Matching the namespace of the array generator

This would remove the requirements of third party plugins for visualization.

* Removal of all visualization messages from perception nodes * Visualization dependency removal * Launch file modification

* Error on Clustering CPU

k0suke-murakami · 2018-10-30T02:52:59Z

It seems like there are 4 spaces indent in each block. That leads to modifications in every single code.
According to ros cpp guide, "Indent each block by 2 spaces. " link

Can you modify these part so that diff part would be more clarified?

amc-nu · 2018-10-31T03:10:08Z

got it @cirpue49 doesn't look good (IMO), but as you wish

* Added README

kfunaoka · 2018-10-31T03:40:07Z

ROS clang-format formats code with IndentWidth = 2.

IndentWidth:     2

https://github.com/CPFL/Autoware/wiki/Contribution-Rules#ros-c-coding

k0suke-murakami · 2018-10-31T06:10:36Z

All you have to do is to run find . -name '*.h' -or -name '*.hpp' -or -name '*.cpp' | xargs clang-format-3.8 -i -style=file $1 after setting up in this page

This page can be reached from the webpage @kfunaoka posted.

Could you do this to keep the format for all the Autoware users/contributors?

amc-nu · 2018-10-31T06:26:08Z

It is already applied
-____-

k0suke-murakami · 2018-10-31T06:45:59Z

https://github.com/CPFL/Autoware/blob/feature/perception_visualization_cleanup/ros/src/computing/perception/detection/lidar_tracker/packages/lidar_imm_ukf_pda_track/include/imm_ukf_pda.h#L58

Are you sure?
Also, it is not only about indent.
Please make sure you applied ros clang

amc-nu · 2018-10-31T11:20:04Z

@cirpue49 Done
I recommend you not to use that code. It will apply a style different to http://wiki.ros.org/CppStyleGuide
Specially the Braces:
Both open and close, go on their own lines (no "cuddled braces")

kfunaoka · 2018-11-01T06:36:08Z

@amc-nu Do you use this format file?
https://github.com/davetcoleman/roscpp_code_format/blob/master/.clang-format

* Added valid field for visualization and future compatibility with ADAS ROI filtering

…thub.com/CPFL/Autoware into feature/perception_visualization_cleanup

* keep label of the oldest tracker

…thub.com/CPFL/Autoware into feature/perception_visualization_cleanup

…:CPFL/Autoware into feature/perception_visualization_cleanup

k0suke-murakami

Looks good to me!

* 2D Rect node visualize_rects added to visualization_package

* * Initial commit for visualization package * Removal of all visualization messages from perception nodes * Visualization dependency removal * Launch file modification * * Fixes to visualization * Error on Clustering CPU * Reduce verbosity on markers * intial commit * * Changed to 2 spaces indentation * Added README * Fixed README messages type * 2 space indenting * ros clang format * Publish acceleration and velocity from ukf tracker * Remove hardcoded path * Updated README * updated prototype * Prototype update for header and usage * Removed unknown label from being reported * Updated publishing orientation to match develop * * Published all the trackers * Added valid field for visualization and future compatibility with ADAS ROI filtering * Add simple functions * Refacor code * * Reversed back UKF node to develop * Formatted speed * Refactor codes * Refactor codes * Refactor codes * Refacor codes * Make tracking visualization work * Relay class info in tracker node * Remove dependency to jskbbox and rosmarker in ukf tracker * apply rosclang to ukf tracker * Refactor codes * Refactor codes * add comment * refactor codes * Revert "Refactor codes" This reverts commit 135aaac. * Revert "apply rosclang to ukf tracker" This reverts commit 4f8d1cb. * Revert "Remove dependency to jskbbox and rosmarker in ukf tracker" This reverts commit 4fa1dd4. * Revert "Relay class info in tracker node" This reverts commit 1637baa. * delete dependency to jsk and remove pointcloud_frame * get direction nis * set velocity_reliable true in tracker node * Add divided function * add function * Sanity checks * Relay all the data from input DetectedObject * Divided function work both for immukf and sukf * Add comment * Refactor codes * Pass immukf test * make direction assisted tracking work * Visualization fixes * Refacor codes * Refactor codes * Refactor codes * refactor codes * refactor codes * Refactor codes * refactor codes * Tracker Merging step added * Added launch file support for merging phase * lane assisted with sukf * Refactor codes * Refactor codes * * change only static objects * keep label of the oldest tracker * Static Object discrimination * Non rotating bouding box * no disappear if detector works * Modify removeRedundant a bit * Replacement of JSK visualization for RViz Native Markers * Added Models namespace to visualization * Naming change for matching the perception component graph * * Added 3D Models for different classes in visualization * 2D Rect node visualize_rects added to visualization_package

amc-nu added 2 commits October 26, 2018 13:57

* Initial commit for visualization package

180900c

* Removal of all visualization messages from perception nodes * Visualization dependency removal * Launch file modification

Merge branch 'develop' into feature/perception_visualization_cleanup

0c2df3e

amc-nu requested review from k0suke-murakami and kfunaoka October 26, 2018 05:06

amc-nu added 2 commits October 26, 2018 20:01

* Fixes to visualization

7a59696

* Error on Clustering CPU

Reduce verbosity on markers

6a05d7e

intial commit

923e468

* Changed to 2 spaces indentation

a92460c

* Added README

Fixed README messages type

d807166

2 space indenting

6040437

amc-nu and others added 12 commits November 1, 2018 16:43

ros clang format

752161e

Publish acceleration and velocity from ukf tracker

161cbff

Merge branch 'develop' into feature/perception_visualization_cleanup

c861aa8

Remove hardcoded path

900bcf7

Updated README

15d5286

updated prototype

56fdc09

Prototype update for header and usage

ea4886d

Removed unknown label from being reported

887d45a

Updated publishing orientation to match develop

83e1b54

* Published all the trackers

1bfbfe6

* Added valid field for visualization and future compatibility with ADAS ROI filtering

merge develop

15c7663

Add simple functions

855ba4a

koh-murakami-ai and others added 23 commits November 9, 2018 16:39

refactor codes

e765b1a

Merge branch 'develop' into feature/perception_visualization_cleanup

859d06f

Refactor codes

5249f55

merge feature/tracking_with_adas branch

2e60f30

refactor codes

c3c0b33

Tracker Merging step added

fa7d657

Merge branch 'feature/perception_visualization_cleanup' of https://gi…

4fd3f63

…thub.com/CPFL/Autoware into feature/perception_visualization_cleanup

Added launch file support for merging phase

ff06bb9

lane assisted with sukf

ec4f7d4

Lane assisted tracking with standard ukf

8d940be

Refactor codes

9ff8ea3

Refactor codes

532d6a4

* change only static objects

fa82081

* keep label of the oldest tracker

Merge branch 'feature/perception_visualization_cleanup' of https://gi…

2eb8511

…thub.com/CPFL/Autoware into feature/perception_visualization_cleanup

Static Object discrimination

7d7e667

Merge branch 'develop' into feature/perception_visualization_cleanup

f53f228

Non rotating bouding box

30ac387

Merge branch 'feature/perception_visualization_cleanup' of github.com…

13b3f66

…:CPFL/Autoware into feature/perception_visualization_cleanup

no disappear if detector works

d420e0c

Modify removeRedundant a bit

c09f8e7

Replacement of JSK visualization for RViz Native Markers

57a6549

Added Models namespace to visualization

f699abf

Naming change for matching the perception component graph

9f73bf1

k0suke-murakami approved these changes Dec 10, 2018

View reviewed changes

* Added 3D Models for different classes in visualization

28b5248

* 2D Rect node visualize_rects added to visualization_package

amc-nu merged commit 47d36ea into develop Dec 12, 2018

amc-nu deleted the feature/perception_visualization_cleanup branch December 12, 2018 11:23

amc-nu added this to the v1.10 milestone Dec 13, 2018

mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/perception visualization cleanup #1648

Feature/perception visualization cleanup #1648

amc-nu commented Oct 26, 2018 •

edited

Loading

k0suke-murakami commented Oct 30, 2018

amc-nu commented Oct 31, 2018

kfunaoka commented Oct 31, 2018

k0suke-murakami commented Oct 31, 2018

amc-nu commented Oct 31, 2018

k0suke-murakami commented Oct 31, 2018

amc-nu commented Oct 31, 2018 •

edited

Loading

kfunaoka commented Nov 1, 2018

k0suke-murakami left a comment

Feature/perception visualization cleanup #1648

Feature/perception visualization cleanup #1648

Conversation

amc-nu commented Oct 26, 2018 • edited Loading

Status

Description

Related PRs

Steps to Test or Reproduce

k0suke-murakami commented Oct 30, 2018

amc-nu commented Oct 31, 2018

kfunaoka commented Oct 31, 2018

k0suke-murakami commented Oct 31, 2018

amc-nu commented Oct 31, 2018

k0suke-murakami commented Oct 31, 2018

amc-nu commented Oct 31, 2018 • edited Loading

kfunaoka commented Nov 1, 2018

k0suke-murakami left a comment

Choose a reason for hiding this comment

amc-nu commented Oct 26, 2018 •

edited

Loading

amc-nu commented Oct 31, 2018 •

edited

Loading