add param to override lane_departure_check when starting outside lane
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 1 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Large Method manager.cpp: StartPlannerModuleManager::updateModuleParams
- Large Method manager.cpp: StartPlannerModuleManager::init
✅ Improving Code Health:
- Lines of Code in a Single File start_planner_module.cpp 🔥
- Complex Method start_planner_module.cpp: StartPlannerModule::plan 🔥
Annotations
Check notice on line 1 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1301 to 1282, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 478 in planning/behavior_path_start_planner_module/src/start_planner_module.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Complex Method
StartPlannerModule::plan decreases in cyclomatic complexity from 17 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 397 in planning/behavior_path_start_planner_module/src/manager.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
StartPlannerModuleManager::updateModuleParams increases from 322 to 325 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check warning on line 58 in planning/behavior_path_start_planner_module/src/manager.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
StartPlannerModuleManager::init increases from 267 to 269 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.