-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware_
prefix for diagnostic_graph_utils
#9968
feat: apply autoware_
prefix for diagnostic_graph_utils
#9968
Conversation
Note: * In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* To follow the previous commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9968 +/- ##
==========================================
+ Coverage 29.74% 29.77% +0.02%
==========================================
Files 1435 1446 +11
Lines 108308 108613 +305
Branches 42955 43027 +72
==========================================
+ Hits 32221 32337 +116
- Misses 72958 73138 +180
- Partials 3129 3138 +9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not change the copyright publication year.
…stic-graph-utils Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* Following the comment: - https://github.com/autowarefoundation/autoware.universe/pull/9968/files#r1923419643 Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…utils' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-system-diagnostic-graph-utils Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…stic-graph-utils Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…n-dependency-in-tier4-simulator-launch'
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…stic_graph_utils Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
…ostic_graph_utils Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
This has to be merged with tier4/autoware_launch#741 |
…refix-for-system-diagnostic-graph-utils
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
This PR is tested with the
autoware_internal_msgs
with1.4.0
due to the following error I observedCurrently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Executed Commands (which succeeded)
Directory Name
autoware_
as a prefix to the directory name.packages.xml
autoware_
to thename
element.CMakeLists.txt
project
name toautoware_***
.autoware::
toPLUGIN
.Header Files (.hpp)
#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.Source Files (.cpp)
autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.Launch Files
autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.Include
autoware
folder as necessary and update include statements accordingly.Verification Points
find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
diagnostic_graph_utils
needs to modify their code. This is maybe kind of non quick-win task.