-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apply autoware_
prefix for scenario_simulator_v2_adapter
#9957
feat: apply autoware_
prefix for scenario_simulator_v2_adapter
#9957
Conversation
…x (see below): * In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…toware`: * Fixes due to this changes for .hpp/.cpp files will be applied in the next commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
* To follow the previous commit Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…or_v2_adapter` Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9957 +/- ##
==========================================
- Coverage 29.76% 29.49% -0.27%
==========================================
Files 1434 1425 -9
Lines 108244 107739 -505
Branches 42930 42787 -143
==========================================
- Hits 32222 31781 -441
- Misses 72893 72895 +2
+ Partials 3129 3063 -66
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nario-simulator-v2-adapter
Please test it with this catalog to check if you branch pass all scenarios(1-2 failures is ok.), which contains many scenarios using scenario_simulator_v2_adapter. |
…nario-simulator-v2-adapter Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…opyrights Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…t needed here Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…ator-v2-adapter' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-evaluator-scenario-simulator-v2-adapter Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…nario-simulator-v2-adapter
…nario-simulator-v2-adapter Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…ator-v2-adapter' of github.com:sasakisasaki/autoware.universe into feat-apply-autoware-prefix-for-evaluator-scenario-simulator-v2-adapter Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
…unch side Signed-off-by: Junya Sasaki <junya.sasaki@tier4.jp>
@xtk8532704 @maxime-clem Thank you for all your support and review! Now tested as this result. Without the testing on evaluator, I could not detect lots of issues. I appreciate all your reviews! |
…nario-simulator-v2-adapter
Description
This pull request addresses the issue of inconsistent naming by adding the
autoware_
prefix to relevant components. This change ensures uniformity across the codebase and aligns with the project's naming conventions.Related Links
How was this PR tested?
Currently, we only verified that the build succeeds. Further checks will be performed by using the updated module. This PR will be ready for review after finishing all the necessary checks/tests.
Executed Commands (which succeeded)
autoware_
as a prefix to the directory name.autoware_
to thename
element.project
name toautoware_***
.autoware::
toPLUGIN
.#ifndef
guards withAUTOWARE__
.autoware::
tonamespace
.autoware::
insideRCLCPP_COMPONENTS_REGISTER_NODE
.autoware_
beforefind-pkg-share
.node pkg="<pkgname>"
toautoware_<pkgname>
.autoware
folder as necessary and update include statements accordingly.find-pkg-share
in autowaresensor_launch
as seen ingnss_poser
Notes for Reviewers
None.
Interface Changes
None.
Effects on System Behavior
All the developers who were using
scenario_simulator_v2_adapter
needs to modify their code. This is maybe kind of non quick-win task.