Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start_planner, goal_planner): refactor lane departure checker initialization #9944

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 16, 2025

Description

Fixes a bug in LaneDepartureChecker parameter initialization where only footprint_extra_margin needed to be updated.
Changes the initialization pattern to properly update only the footprint_extra_margin parameter.

Related links

Parent Issue:

  • Link

How was this PR tested?

Confirmed that setting a sufficiently large value for lane_departure_check_expansion_margin prevents path generation from goal_planner module when setting goals near the lane edges.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…on for clarity

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 16, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 29.13%. Comparing base (cde1c78) to head (df80610).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dule/src/pull_over_planner/geometric_pull_over.cpp 0.00% 5 Missing ⚠️
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9944      +/-   ##
==========================================
- Coverage   29.14%   29.13%   -0.02%     
==========================================
  Files        1425     1428       +3     
  Lines      107819   107877      +58     
  Branches    42246    42245       -1     
==========================================
+ Hits        31422    31427       +5     
- Misses      73352    73405      +53     
  Partials     3045     3045              
Flag Coverage Δ *Carryforward flag
differential 9.81% <44.44%> (?)
total 29.14% <ø> (-0.01%) ⬇️ Carriedforward from cde1c78

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 62e07a1 into autowarefoundation:main Jan 16, 2025
47 of 48 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the fix/start_goal_planner/lane_departure_checker_initialization branch January 16, 2025 14:28
TetsuKawa pushed a commit to TetsuKawa/autoware.universe that referenced this pull request Jan 20, 2025
…tialization (autowarefoundation#9944)

Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants