Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_launch): rearrange roi based cluster pipeline #9938

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jan 16, 2025

Description

  • To avoid duplication of roi_pointcloud_fusion and roi_cluster_fusion on unknown objects
  • Roi_based_cluster pipeline
Before After
image image

Related links

Parent Issue:

  • Link

How was this PR tested?

  • Run logging_simulator with diffrent options of 'use_roi_based_cluster and use_low_intensity_cluster_filter and confirmed that perception model output predict/objects as disired.

    • use_roi_based_cluster:=true, use_low_intensity_cluster_filter:=true:
      image

    • use_roi_based_cluster:=true, use_low_intensity_cluster_filter:=false:
      image

    • use_roi_based_cluster:=false, use_low_intensity_cluster_filter:=false:
      image

    • use_roi_based_cluster:=false, use_low_intensity_cluster_filter:=true:
      image

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@badai-nguyen badai-nguyen force-pushed the fix/roi_pointcloud_fusion_pipeline branch from db5e396 to 4bc1dc1 Compare January 16, 2025 12:43
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@badai-nguyen badai-nguyen force-pushed the fix/roi_pointcloud_fusion_pipeline branch from 4bc1dc1 to eb922be Compare January 20, 2025 08:01
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 20, 2025
@badai-nguyen badai-nguyen marked this pull request as ready for review January 20, 2025 08:13
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit bbf7f66 into autowarefoundation:main Jan 21, 2025
37 of 38 checks passed
@badai-nguyen badai-nguyen deleted the fix/roi_pointcloud_fusion_pipeline branch January 21, 2025 11:57
@badai-nguyen badai-nguyen added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants