Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): fix geometric pull over #9932

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 16, 2025

Description

geometric pull over was broken with #9832

parameter setting is missing

image

Related links

Parent Issue:

  • Link

How was this PR tested?

psim
geometric pull over works

image

2025/01/16 https://evaluation.tier4.jp/evaluation/reports/5cc00185-60bd-5c1b-a93f-9fecf555346a/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 16, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.21%. Comparing base (b69241f) to head (0438ffb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...dule/src/pull_over_planner/geometric_pull_over.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9932      +/-   ##
==========================================
- Coverage   29.23%   29.21%   -0.02%     
==========================================
  Files        1426     1431       +5     
  Lines      107733   107806      +73     
  Branches    42199    42200       +1     
==========================================
  Hits        31494    31494              
- Misses      73192    73265      +73     
  Partials     3047     3047              
Flag Coverage Δ *Carryforward flag
differential 0.51% <0.00%> (?)
total 29.23% <ø> (ø) Carriedforward from b69241f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 enabled auto-merge (squash) January 16, 2025 04:34
@kosuke55 kosuke55 merged commit 347a2e4 into autowarefoundation:main Jan 16, 2025
47 of 48 checks passed
@kosuke55 kosuke55 deleted the fix/geometric_pull_over branch January 16, 2025 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants