Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tracking_object_merger)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_tracking_object_merger #9899

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 14, 2025

…es perception/autoware_tracking_object_merger

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

autowarefoundation/autoware#5580

Related links

Parent Issue:

autowarefoundation/autoware#5580

How was this PR tested?

Test are done in the following TIER IV internal evaluator:

https://evaluation.ci.tier4.jp/evaluation/reports/bfc0e074-207b-5ece-83e5-fb769f6f7272?project_id=prd_jt
https://evaluation.ci.tier4.jp/evaluation/reports/4df9332b-024e-5907-ada9-fbbcb8c20b3d?project_id=prd_jt
https://evaluation.ci.tier4.jp/evaluation/reports/ce1a0892-d8aa-5729-b25d-6d2d57bea034?project_id=prd_jt

Notes for reviewers

None.

Interface changes

Topic Type Topic Name Old Message Type New Message Type
Pub debug/cyclic_time_ms tier4_debug_msgs/Float64Stamped autoware_internal_debug_msgs/Float64Stamped
Pub debug/processing_time_ms tier4_debug_msgs/Float64Stamped autoware_internal_debug_msgs/Float64Stamped

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! could you link the parent issue to this PR description?

@vish0012
Copy link
Contributor Author

Thanks! could you link the parent issue to this PR description?

thank you for your comment , i have updated the link in PR description.

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2025
@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in fil… feat(autoware_tracking_object_merger!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_tracking_object_merger Jan 17, 2025
@mitsudome-r mitsudome-r changed the title feat(autoware_tracking_object_merger!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_tracking_object_merger feat(autoware_tracking_object_merger)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in autoware_tracking_object_merger Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.21%. Comparing base (96708f9) to head (e4ec15c).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...ject_merger/src/decorative_tracker_merger_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9899      +/-   ##
==========================================
- Coverage   29.46%   29.21%   -0.26%     
==========================================
  Files        1417     1410       -7     
  Lines      107419   107148     -271     
  Branches    42562    42454     -108     
==========================================
- Hits        31651    31300     -351     
+ Misses      72687    72629      -58     
- Partials     3081     3219     +138     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 29.21% <ø> (-0.25%) ⬇️ Carriedforward from b7b3dd6

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…es perception/autoware_tracking_object_merger

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
@mitsudome-r mitsudome-r force-pushed the replace_debug_msgs_tracking_object_merger branch from 26a6abd to e4ec15c Compare January 21, 2025 05:30
Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vish0012
Please fill "How was this PR tested?". You need to check this PR by running autoware.
Please fill "Interface changes"

Copy link
Contributor

@Shin-kyoto Shin-kyoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • I confirm that the content is good to merge and the test result shows this PR is properly tested to ensure it will not introduce any bugs.
  • I did NOT check this PR by running autoware.

@mitsudome-r mitsudome-r merged commit fa4f023 into autowarefoundation:main Jan 23, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants