-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce calc cost of occ grid outlier filter #979
feat: reduce calc cost of occ grid outlier filter #979
Conversation
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
========================================
- Coverage 9.67% 9.53% -0.14%
========================================
Files 947 941 -6
Lines 63380 58389 -4991
Branches 10964 10577 -387
========================================
- Hits 6132 5570 -562
+ Misses 52279 48102 -4177
+ Partials 4969 4717 -252
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#979) Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com> Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
chore: sync upstream
Signed-off-by: Yukihiro Saito yukky.saito@gmail.com
Description
Sometimes the execution time of the occupancy grid map based outlier filter node is long.
After analysis, radiusSearch was dominant.
In this PR, it is reduced calc cost of the node
With my sample code, the result is shown in the following.
Note that the result depends on pointcloud data distribution.
https://pointclouds.org/documentation/classpcl_1_1search_1_1_kd_tree.html
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.