Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce calc cost of occ grid outlier filter #979

Conversation

yukkysaito
Copy link
Contributor

@yukkysaito yukkysaito commented May 27, 2022

Signed-off-by: Yukihiro Saito yukky.saito@gmail.com

Description

Sometimes the execution time of the occupancy grid map based outlier filter node is long.
After analysis, radiusSearch was dominant.
In this PR, it is reduced calc cost of the node

With my sample code, the result is shown in the following.
Note that the result depends on pointcloud data distribution.
https://pointclouds.org/documentation/classpcl_1_1search_1_1_kd_tree.html

max_nn == 10: 20msec
max_nn == 100: 100msec
max_nn == none : 2329msec

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #979 (ca3ef5b) into main (7b5b88d) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #979      +/-   ##
========================================
- Coverage   9.67%   9.53%   -0.14%     
========================================
  Files        947     941       -6     
  Lines      63380   58389    -4991     
  Branches   10964   10577     -387     
========================================
- Hits        6132    5570     -562     
+ Misses     52279   48102    -4177     
+ Partials    4969    4717     -252     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.55% <0.00%> (-0.11%) ⬇️ Carriedforward from 7270523

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ier4_perception_rviz_plugin/src/tools/car_pose.cpp 0.00% <0.00%> (ø)
...ption_rviz_plugin/src/tools/interactive_object.hpp 0.00% <ø> (ø)
...nd_segmentation/src/scan_ground_filter_nodelet.cpp 0.00% <0.00%> (ø)
.../src/occupancy_grid_map_outlier_filter_nodelet.cpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
...d_api_msgs/srv/interface_version__type_support.cpp 0.00% <0.00%> (-54.55%) ⬇️
.../_autoware_ad_api_msgs_s.ep.rosidl_typesupport_c.c 0.00% <0.00%> (-51.81%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
...l/dds_fastrtps/interface_version__type_support.cpp 0.00% <0.00%> (-32.72%) ⬇️
... and 612 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebfeeb...ca3ef5b. Read the comment docs.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito enabled auto-merge (squash) May 30, 2022 09:24
@yukkysaito yukkysaito merged commit 4695f2e into autowarefoundation:main May 30, 2022
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
…#979)

Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Nov 16, 2023
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants