Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): add info text to virtual wall #9783

Merged

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Dec 25, 2024

Description

add text to lane change stop wall to provide information for reason of stopping.

When there are valid candidate paths but none are safe, stop wall will be placed at terminal start with the following text lane_change_direction (no safe path) as shown below.
Screenshot from 2024-12-25 11-02-41

When there are no valid candidate paths , stop wall will be placed at terminal start with the following text lane_change_direction (no valid path) as shown below.
Screenshot from 2024-12-25 16-07-37

When there is stopped front object along current lane and there is no blocking object on target lane, stop wall will be placed at a distance from front object with following text lane_change_direction (maintain distance to front object) as shown below.
Screenshot from 2024-12-25 11-02-07

Related links

Parent Issue:

  • Link

How was this PR tested?

  • PSIM.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

mkquda and others added 3 commits December 24, 2024 18:05
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 29.71%. Comparing base (421ec7d) to head (0070b16).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...are_behavior_path_lane_change_module/src/scene.cpp 0.00% 10 Missing ⚠️
...behavior_path_lane_change_module/src/interface.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9783      +/-   ##
==========================================
- Coverage   29.72%   29.71%   -0.01%     
==========================================
  Files        1451     1453       +2     
  Lines      108839   108870      +31     
  Branches    42741    42746       +5     
==========================================
+ Hits        32348    32350       +2     
- Misses      73313    73342      +29     
  Partials     3178     3178              
Flag Coverage Δ *Carryforward flag
differential 20.94% <0.00%> (?)
total 29.72% <ø> (+<0.01%) ⬆️ Carriedforward from 421ec7d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkquda mkquda merged commit a7655bc into autowarefoundation:main Dec 25, 2024
46 of 50 checks passed
@mkquda mkquda deleted the RT1-8913-add-info-text-to-virtual-wall branch December 25, 2024 07:41
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…9783)

* specify reason for lane change stop line

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

* add stop reason for incoming rear object

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>

---------

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants