-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): add info text to virtual wall #9783
feat(lane_change): add info text to virtual wall #9783
Conversation
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9783 +/- ##
==========================================
- Coverage 29.72% 29.71% -0.01%
==========================================
Files 1451 1453 +2
Lines 108839 108870 +31
Branches 42741 42746 +5
==========================================
+ Hits 32348 32350 +2
- Misses 73313 73342 +29
Partials 3178 3178
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…9783) * specify reason for lane change stop line Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> * add stop reason for incoming rear object Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp> --------- Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Description
add text to lane change stop wall to provide information for reason of stopping.
When there are valid candidate paths but none are safe, stop wall will be placed at terminal start with the following text
![Screenshot from 2024-12-25 11-02-41](https://private-user-images.githubusercontent.com/168697710/398530680-467e77dc-c928-48fa-a428-b4bf3a542c4f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzkxOTIsIm5iZiI6MTczOTMzODg5MiwicGF0aCI6Ii8xNjg2OTc3MTAvMzk4NTMwNjgwLTQ2N2U3N2RjLWM5MjgtNDhmYS1hNDI4LWI0YmYzYTU0MmM0Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNTQxMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01Zjc4NWRmYTE2ZGVkZTM2MTFhNTc4NzYwZWNhNDgwNWU2YmE3YjA3ODgwNDZkZDc0NWYxNjY2YmUyNTQ1YTQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.BMo3Z_Yup1EJGrygca0-v_-FX_Qct3zQDcwcZ6T3Pr8)
lane_change_direction (no safe path)
as shown below.When there are no valid candidate paths , stop wall will be placed at terminal start with the following text
![Screenshot from 2024-12-25 16-07-37](https://private-user-images.githubusercontent.com/168697710/398530861-ffe2e7b1-1d12-46b4-b28e-4ed8ddb0ac16.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzkxOTIsIm5iZiI6MTczOTMzODg5MiwicGF0aCI6Ii8xNjg2OTc3MTAvMzk4NTMwODYxLWZmZTJlN2IxLTFkMTItNDZiNC1iMjhlLTRlZDhkZGIwYWMxNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNTQxMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NmMwZTk3YmFhMGQ4NjYzZjNkY2E3OTQ2NjkyNzAzZGRmOWQ1ZDljNGUxNDFlMGEyYTQ5NDcyYjVkYTgzZWRjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.uFdduMfsHjhMkM3phecXVriHW3bJJV1AvzIsSvA2Mc0)
lane_change_direction (no valid path)
as shown below.When there is stopped front object along current lane and there is no blocking object on target lane, stop wall will be placed at a distance from front object with following text
![Screenshot from 2024-12-25 11-02-07](https://private-user-images.githubusercontent.com/168697710/398531566-7adc4bd0-7d02-4a0b-acce-859c53f47489.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzkxOTIsIm5iZiI6MTczOTMzODg5MiwicGF0aCI6Ii8xNjg2OTc3MTAvMzk4NTMxNTY2LTdhZGM0YmQwLTdkMDItNGEwYi1hY2NlLTg1OWM1M2Y0NzQ4OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNTQxMzJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NjJiMmY0Y2ZlZmQ2MTVlMzU5ZThmOWQ3OTc0MGJjYjVhMzdmOWMwOWE3ZGJmN2U2YmFiOGFmYmRjMzljMGMwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.crmRJOKR9Kd6OcqNSdGpLn7I6mP6NInDjDpq0Tt41lc)
lane_change_direction (maintain distance to front object)
as shown below.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.