Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_motion_velocity_obstacle_velocity_limiter_module): fix bugprone-exception-escape #9779

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-exception-escape error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/motion_velocity_planner/autoware_motion_velocity_obstacle_velocity_limiter_module/benchmarks/collision_checker_benchmark.cpp:56:5: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
int main()
    ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@kobayu858 kobayu858 requested a review from veqcc December 25, 2024 05:51
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 29.67%. Comparing base (3d53032) to head (1a09968).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
..._module/benchmarks/collision_checker_benchmark.cpp 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9779      +/-   ##
==========================================
+ Coverage   29.66%   29.67%   +0.01%     
==========================================
  Files        1450     1454       +4     
  Lines      108833   108872      +39     
  Branches    42740    42740              
==========================================
+ Hits        32285    32311      +26     
- Misses      73375    73392      +17     
+ Partials     3173     3169       -4     
Flag Coverage Δ *Carryforward flag
differential 16.24% <0.00%> (?)
total 29.68% <ø> (+0.02%) ⬆️ Carriedforward from 3d53032

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit fe597e2 into autowarefoundation:main Dec 25, 2024
36 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 27, 2024
…ugprone-exception-escape (autowarefoundation#9779)

* fix: bugprone-error

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix: cppcheck

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix: cpplint

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants