Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_behavior_velocity_occlusion_spot_module): fix bugprone-macro-parentheses #9712

Merged
merged 3 commits into from
Jan 6, 2025
Merged

fix(autoware_behavior_velocity_occlusion_spot_module): fix bugprone-macro-parentheses #9712

merged 3 commits into from
Jan 6, 2025

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-macro-parentheses error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/behavior_velocity_planner/autoware_behavior_velocity_occlusion_spot_module/src/scene_occlusion_spot.cpp:39:34: error: macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]
    const std::string time_msg = n + std::to_string(x);            \
                                 ^
                                 ()

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@kobayu858
fix: bugprone-error
1508e4e 
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc December 23, 2024 02:43
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
@kobayu858
fix: fmt
afef84c 
Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.72%. Comparing base (a32cae1) to head (86c4235).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9712      +/-   ##
==========================================
+ Coverage   28.77%   29.72%   +0.94%     
==========================================
  Files        1457     1448       -9     
  Lines      109221   107693    -1528     
  Branches    42566    42040     -526     
==========================================
+ Hits        31428    32009     +581     
+ Misses      74714    72546    -2168     
- Partials     3079     3138      +59
Flag Coverage Δ *Carryforward flag
differential 1.59% <ø> (?)
total 29.77% <ø> (+0.99%) ⬆️ Carriedforward from afef84c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858
Copy link
Contributor Author

@shmpwk @taikitanaka3 @tkimura4
Please confirm the PR. Thank you very much.

@kobayu858
Copy link
Contributor Author

@shmpwk @taikitanaka3 @tkimura4
Please confirm the PR. Thank you very much.

shmpwk
shmpwk approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for my late check.

@shmpwk shmpwk enabled auto-merge (squash) January 6, 2025 03:05
taikitanaka3
taikitanaka3 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shmpwk shmpwk merged commit 4a181d6 into autowarefoundation:main Jan 6, 2025
34 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 6, 2025
@kobayu858 @kyoichi-sugahara
fix(autoware_behavior_velocity_occlusion_spot_module): fix bugprone-m…
f02e3fe 
…acro-parentheses (autowarefoundation#9712)

* fix: bugprone-error

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

* fix: fmt

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>

---------

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@veqcc veqcc mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmpwk shmpwk shmpwk approved these changes

@taikitanaka3 taikitanaka3 taikitanaka3 approved these changes

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@veqcc veqcc Awaiting requested review from veqcc

Assignees
No one assigned
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Software Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kobayu858 @shmpwk @taikitanaka3