Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_interpolation): remove clang compiler error #9711

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Dec 23, 2024

Description

Fixed clang complier error

--- stderr: autoware_interpolation                               
/home/veqcc/work/autoware/src/universe/autoware.universe/common/autoware_interpolation/test/src/test_interpolation_utils.cpp:21:18: error: unused variable 'epsilon' [-Werror,-Wunused-const-variable]
constexpr double epsilon = 1e-6;
                 ^
1 error generated.
gmake[2]: *** [CMakeFiles/test_interpolation.dir/build.make:90: CMakeFiles/test_interpolation.dir/test/src/test_interpolation_utils.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/test_interpolation.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< autoware_interpolation [0.92s, exited with code 2]

Related links

Parent Issue:

  • Link

How was this PR tested?

build and test

$ colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_interpolation
Starting >>> autoware_planning_msgs
Starting >>> autoware_common_msgs
Starting >>> autoware_lint_common
Starting >>> autoware_perception_msgs
Starting >>> autoware_internal_msgs
Starting >>> tier4_debug_msgs
Finished <<< autoware_lint_common [0.26s]                                                                                                                                                   
Starting >>> autoware_cmake
Finished <<< autoware_cmake [0.28s]                                                                                                                                                           
Finished <<< autoware_common_msgs [1.45s]                                                                                                                                                        
Finished <<< autoware_internal_msgs [1.47s]
Finished <<< tier4_debug_msgs [1.48s]                                                                                                                 
Finished <<< autoware_perception_msgs [1.73s]                                                                            
Finished <<< autoware_planning_msgs [1.77s]
Starting >>> autoware_vehicle_msgs
Starting >>> tier4_planning_msgs
Finished <<< autoware_vehicle_msgs [1.97s]                                                                     
Finished <<< tier4_planning_msgs [2.44s]                      
Starting >>> autoware_universe_utils
Finished <<< autoware_universe_utils [2.01s]                     
Starting >>> autoware_interpolation
Finished <<< autoware_interpolation [2.03s]                    

Summary: 11 packages finished [9.76s]
$ colcon test --packages-select autoware_interpolation
Starting >>> autoware_interpolation
Finished <<< autoware_interpolation [2.54s]          

Summary: 1 package finished [4.03s]

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: veqcc <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc self-assigned this Dec 23, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
@veqcc veqcc enabled auto-merge (squash) December 23, 2024 03:02
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.79%. Comparing base (9bc173c) to head (fa4edda).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9711      +/-   ##
==========================================
+ Coverage   29.74%   29.79%   +0.04%     
==========================================
  Files        1444     1445       +1     
  Lines      108693   108703      +10     
  Branches    42665    42665              
==========================================
+ Hits        32336    32383      +47     
+ Misses      73175    73132      -43     
- Partials     3182     3188       +6     
Flag Coverage Δ *Carryforward flag
differential 30.33% <ø> (?)
total 29.74% <ø> (ø) Carriedforward from 8949358

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 07db183 into autowarefoundation:main Dec 23, 2024
35 checks passed
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 25, 2024
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants